linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sahitya Tummala <stummala@codeaurora.org>
To: Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: e2fsck on encrypted directories
Date: Fri, 28 Jul 2017 15:32:24 +0530	[thread overview]
Message-ID: <23b72f10-bbe6-1e7d-89b6-7b8bebab8d13@codeaurora.org> (raw)

Hi Ted,

I got a question on usage of e2fsck with -D option on EXT4 FS, where
file based encryption is enabled. Is this option supposed to work on
encrypted directories?

I have encountered a case where e2fsck gets stuck
in duplicate_search_and_fix() due to strncmp checks done in this function
on encrypted file names, which may contain NUL characters.

Also, even without -D option passed, there can be a case of duplicate 
entries (i.e.,
ctx->dirs_to_hash is not NULL). In this case too we may see the same issue
in duplicate_search_and_fix() if the directory is encrypted.
Is my understanding correct? Please share your comments.

Thanks,
Sahitya.

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

             reply	other threads:[~2017-07-28 10:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 10:02 Sahitya Tummala [this message]
2017-08-01 14:33 ` e2fsck on encrypted directories Theodore Ts'o
2017-08-01 19:18   ` Eric Biggers
2017-08-02  7:13   ` Sahitya Tummala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23b72f10-bbe6-1e7d-89b6-7b8bebab8d13@codeaurora.org \
    --to=stummala@codeaurora.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).