From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, tytso@mit.edu
Subject: Re: [PATCH 7/7] fsverity: Remove filesystem specific build config option
Date: Tue, 27 Nov 2018 19:01:28 +0530 [thread overview]
Message-ID: <2413763.K7ZbsYlPLa@localhost.localdomain> (raw)
In-Reply-To: <20181127004530.GF11663@gmail.com>
On Tuesday, November 27, 2018 6:15:30 AM IST Eric Biggers wrote:
> Hi Chandan,
>
> On Mon, Nov 19, 2018 at 10:53:24AM +0530, Chandan Rajendra wrote:
> > In order to have a common code base for fsverity "post read" processing
> > for all filesystems which support per-file verity, this commit removes
> > filesystem specific build config option (e.g. CONFIG_EXT4_FS_VERITY) and
> > replaces it with a build option (i.e. CONFIG_FS_VERITY) whose value
> > affects all the filesystems making use of fsverity.
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>
> Like the corresponding fscrypt patch, this is missing changing
>
> #if IS_ENABLED(CONFIG_FS_VERITY)
>
> in include/linux/fs.h to
>
> #ifdef CONFIG_FS_VERITY
>
> There are also references to the filesystem-specific config options in
> Documentation/filesystems/fsverity.rst that need to be updated.
>
> I also suggest updating the Kconfig help text for CONFIG_FS_VERITY and
> CONFIG_FS_ENCRYPTION to mention the supported filesystems, similar to how
> CONFIG_QUOTA lists the filesystems it supports.
>
I will fix this one too.
--
chandan
prev parent reply other threads:[~2018-11-28 0:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 5:23 [PATCH 0/7] Remove fs specific fscrypt and fsverity build config options Chandan Rajendra
2018-11-19 5:23 ` [PATCH 1/7] ext4: use IS_ENCRYPTED() to check encryption status Chandan Rajendra
2018-11-27 0:35 ` Eric Biggers
2018-11-19 5:23 ` [PATCH 2/7] f2fs: " Chandan Rajendra
2018-11-19 6:24 ` Chao Yu
2018-11-19 21:23 ` [f2fs-dev] " Jaegeuk Kim
2018-11-26 3:41 ` Theodore Y. Ts'o
2018-11-26 4:00 ` Theodore Y. Ts'o
2018-11-26 17:34 ` Theodore Y. Ts'o
2018-11-26 23:52 ` Jaegeuk Kim
2018-11-29 10:38 ` Chandan Rajendra
2018-11-29 19:05 ` Eric Biggers
2018-11-30 5:27 ` Chandan Rajendra
2018-11-30 17:44 ` Eric Biggers
2018-11-19 5:23 ` [PATCH 3/7] fscrypt: Remove filesystem specific build config option Chandan Rajendra
2018-11-27 0:14 ` Eric Biggers
2018-11-27 13:29 ` Chandan Rajendra
2018-11-19 5:23 ` [PATCH 4/7] Add S_VERITY and IS_VERITY() Chandan Rajendra
2018-11-27 0:08 ` Eric Biggers
2018-11-27 13:30 ` Chandan Rajendra
2018-11-19 5:23 ` [PATCH 5/7] ext4: use IS_VERITY() to check inode's fsverity status Chandan Rajendra
2018-11-26 17:36 ` Theodore Y. Ts'o
2018-11-27 0:29 ` Eric Biggers
2018-11-27 3:03 ` Chandan Rajendra
2018-11-28 13:49 ` Chandan Rajendra
2018-11-19 5:23 ` [PATCH 6/7] f2fs: " Chandan Rajendra
2018-11-19 6:25 ` [f2fs-dev] " Chao Yu
2018-11-27 0:41 ` Eric Biggers
2018-11-19 5:23 ` [PATCH 7/7] fsverity: Remove filesystem specific build config option Chandan Rajendra
2018-11-27 0:45 ` Eric Biggers
2018-11-27 13:31 ` Chandan Rajendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2413763.K7ZbsYlPLa@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).