public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH e2fsprogs] e2fsck: preen inline data no attr
@ 2026-03-04 13:56 Daniel Tang
  2026-03-06 11:16 ` Andreas Dilger
  2026-03-06 15:51 ` Theodore Tso
  0 siblings, 2 replies; 7+ messages in thread
From: Daniel Tang @ 2026-03-04 13:56 UTC (permalink / raw)
  To: linux-ext4, Theodore Tso, Darrick J. Wong

I don't like being forcibly dropped into an emergency shell to truncate
pidfiles and other temporary files every time my tablet uncleanly shuts
down.

This seems safe. The only thing that should be erased is the size.
The removed inline data flag is remembered by the extent flag being
absent. There is no data to lose because there are no extents/blocks,
and the system.data attribute is already diagnosed missing.

Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>
Link: https://github.com/tytso/e2fsprogs/pull/268
---
 e2fsck/problem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index e433281f..e6f055f2 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -1170,7 +1170,7 @@ static struct e2fsck_problem problem_table[] = {
 	{ PR_1_INLINE_DATA_NO_ATTR,
 	  /* xgettext:no-c-format */
 	  N_("@i %i has INLINE_DATA_FL flag but @a not found.  "),
-	  PROMPT_TRUNCATE, 0, 0, 0, 0 },
+	  PROMPT_TRUNCATE, PR_PREEN_OK, 0, 0, 0 },
 
 	/* Special (device/socket/fifo) file (inode num) has extents
 	 * or inline-data flag set */
-- 
2.51.0





^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-03-08  5:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04 13:56 [PATCH e2fsprogs] e2fsck: preen inline data no attr Daniel Tang
2026-03-06 11:16 ` Andreas Dilger
2026-03-06 15:51 ` Theodore Tso
2026-03-06 18:03   ` Daniel Tang
2026-03-06 22:23     ` Theodore Tso
2026-03-08  1:42       ` Daniel Tang
2026-03-08  5:04         ` Theodore Tso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox