From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
linux-xfs@vger.kernel.org, Jan Kara <jack@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody
Date: Tue, 05 Nov 2019 15:57:13 -0500 [thread overview]
Message-ID: <249994.1572987433@turing-police> (raw)
In-Reply-To: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Mon, 04 Nov 2019 21:46:14 -0500, Valdis Kletnieks said:
> Four filesystems have their own defines for this. Move it
> into errno.h so it's defined in just one place.
>
> Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Going to have to retract this. and the other patch for EFSCORRUPTED.
On Tue, 05 Nov 2019 10:17:52 +0000, Rasmus Villemoes <rasmus.villemoes@prevas.dk> said:
> Does that work? Six architectures (alpha ia64 mips parisc powerpc sparc)
> have their own asm/errno.h. ia64 and powerpc include asm-generic/errno.h
> from their asm/errno.h, but the remaining four will no longer have a
> definition of EFSBADCRC.
I knew some architectures had their own syscall values. I admit it comes as
a surprise to me (and probably a number of others) that errno.h is that way too....
Thanks for spotting this, Rasmus...
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-11-05 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 2:46 [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody Valdis Kletnieks
2019-11-05 9:05 ` Jan Kara
2019-11-05 13:37 ` Theodore Y. Ts'o
2019-11-05 15:17 ` Darrick J. Wong
2019-11-05 20:58 ` Valdis Klētnieks
2019-11-05 20:07 ` Dave Chinner
2019-11-05 20:57 ` Valdis Klētnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=249994.1572987433@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=chao@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).