linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Eugene Teo" <eugeneteo@kernel.sg>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	"Eric Sandeen" <sandeen@redhat.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/4] ext3: Avoid printk floods in the face of directory corruption
Date: Thu, 18 Sep 2008 08:57:19 +0800	[thread overview]
Message-ID: <28fa9c5e0809171757p59978419p810e7d0c571e33e6@mail.gmail.com> (raw)
In-Reply-To: <1221319971-29879-4-git-send-email-tytso@mit.edu>

On Sat, Sep 13, 2008 at 11:32 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> Note: some people thinks this represents a security bug, since it
> might make the system go away while it is printing a large number of
> console messages, especially if a serial console is involved.  Hence,
> it has been assigned CVE-2008-3528, but it requires that the attacker
> either has physical access to your machine to insert a USB disk with a
> corrupted filesystem image (at which point why not just hit the power
> button), or is otherwise able to convince the system administrator to
> mount an arbitrary filesystem image (at which point why not just
> include a setuid shell or world-writable hard disk device file or some
> such).  Me, I think they're just being silly.

The description should explain what the problem is. And the last
sentence is a little ambiguous.

This is a user-triggerable DoS. The administrator who mounted the
filesystem image or partition might not know that the dir->i_size and
dir->i_blocks are corrupted. A remote user just need to perform either
a read or write operation to the mounted image or partition, and this
could trigger the problem, resulting in a denial of service.

Take note that another problem the test image shows is that, the
ext2/3 (and possibly ext4) filesystem does not honour the read-only
mode when the revision level is too high. That is, when
le32_to_cpu(es->s_rev_level) > EXT3_MAX_SUPP_REV. Eric replied me in a
private email that this is a different, and unrelated bug that will be
fixed.

Thanks, Eugene

  reply	other threads:[~2008-09-18  0:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-13 15:32 [PATCH 1/4] ext3: Fix ext3_dx_readdir hash collision handling Theodore Ts'o
2008-09-13 15:32 ` [PATCH 2/4] ext3: truncate block allocated on a failed ext3_write_begin Theodore Ts'o
2008-09-13 15:32   ` [PATCH 3/4] ext2: Avoid printk floods in the face of directory corruption Theodore Ts'o
2008-09-13 15:32     ` [PATCH 4/4] ext3: " Theodore Ts'o
2008-09-18  0:57       ` Eugene Teo [this message]
2008-09-17 19:25     ` [PATCH 3/4] ext2: " Andrew Morton
2008-09-17 19:30       ` Eric Sandeen
2008-09-18  9:46     ` Eugene Teo
2008-09-17 19:22   ` [PATCH 2/4] ext3: truncate block allocated on a failed ext3_write_begin Andrew Morton
2008-09-18  7:03     ` Aneesh Kumar K.V
2008-09-17 19:19 ` [PATCH 1/4] ext3: Fix ext3_dx_readdir hash collision handling Andrew Morton
2008-10-01 22:37   ` Theodore Tso
2008-10-01 23:33     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28fa9c5e0809171757p59978419p810e7d0c571e33e6@mail.gmail.com \
    --to=eugeneteo@kernel.sg \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).