linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@dilger.ca>
To: Lukas Czerner <lczerner@redhat.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH] ext4: Reserve FEATURE_RO_COMPAT and INO flag
Date: Fri, 26 Apr 2013 05:47:58 -0600	[thread overview]
Message-ID: <2B5199BA-39D5-4118-B4FC-96C8B800507B@dilger.ca> (raw)
In-Reply-To: <1366900760-18899-1-git-send-email-lczerner@redhat.com>

I was looking in the maint and master branches, but I don't see these flags anywhere?

Cheers, Andreas

On 2013-04-25, at 8:39, Lukas Czerner <lczerner@redhat.com> wrote:

> EXT4_FEATURE_RO_COMPAT_REPLICA and EXT4_REPLICA_INO are reserved in
> e2fsprogs for non-upstream feature. However it has never been reserved
> in kernel, fix this. Thanks to Radek Pazdera to pointing it out.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> fs/ext4/ext4.h |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 3b83cd6..6369c28 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -241,6 +241,7 @@ struct ext4_io_submit {
> #define EXT4_UNDEL_DIR_INO     6    /* Undelete directory inode */
> #define EXT4_RESIZE_INO         7    /* Reserved group descriptors inode */
> #define EXT4_JOURNAL_INO     8    /* Journal inode */
> +#define EXT4_REPLICA_INO     10    /* Used by non-upstream feature */
> 
> /* First non-reserved inode for old ext4 filesystems */
> #define EXT4_GOOD_OLD_FIRST_INO    11
> @@ -1481,6 +1482,8 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
>  * GDT_CSUM bits are mutually exclusive.
>  */
> #define EXT4_FEATURE_RO_COMPAT_METADATA_CSUM    0x0400
> +/* Reserved for non-upstream feature */
> +#define EXT4_FEATURE_RO_COMPAT_REPLICA        0x0800
> 
> #define EXT4_FEATURE_INCOMPAT_COMPRESSION    0x0001
> #define EXT4_FEATURE_INCOMPAT_FILETYPE        0x0002
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-04-26 11:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 14:39 [PATCH] ext4: Reserve FEATURE_RO_COMPAT and INO flag Lukas Czerner
2013-04-26 11:47 ` Andreas Dilger [this message]
2013-04-29 12:58   ` Lukáš Czerner
2013-04-29 18:35     ` Andreas Dilger
2013-05-03  6:53       ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2B5199BA-39D5-4118-B4FC-96C8B800507B@dilger.ca \
    --to=adilger@dilger.ca \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).