From: Stefan Wahren <stefan.wahren@i2se.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org,
Thorsten Leemhuis <regressions@leemhuis.info>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
Ted Tso <tytso@mit.edu>
Subject: Re: [PATCH 0/5 v3] ext4: Fix performance regression with mballoc
Date: Sun, 11 Sep 2022 14:32:45 +0200 [thread overview]
Message-ID: <2eff8cbd-2d9c-0fb8-cfdb-31ce3534e466@i2se.com> (raw)
In-Reply-To: <20220909104014.xgzdlzem3f7mbccd@quack3>
Hi Jan,
Am 09.09.22 um 12:40 schrieb Jan Kara:
> On Thu 08-09-22 12:36:10, Stefan Wahren wrote:
>> Hi Jan,
>>
>> Am 08.09.22 um 11:21 schrieb Jan Kara:
>>> Hello,
>>>
>>> Here is the third version of my mballoc improvements to avoid spreading
>>> allocations with mb_optimize_scan=1. Since v2 there are only small changes and
>>> fixes found during review and testing. Overall the series looks mostly ready to
>>> go, I just didn't see any comments regarding patch 3 - a fix of metabg handling
>>> in the Orlov allocator which is kind of independent, I've just found it when
>>> reading the code. Also patch 5 needs final review after all the fixes.
>>>
>>> Changes since v1:
>>> - reworked data structure for CR 1 scan
>>> - make small closed files use locality group preallocation
>>> - fix metabg handling in the Orlov allocator
>>>
>>> Changes since v2:
>>> - whitespace fixes
>>> - fix outdated comment
>>> - fix handling of mb_structs_summary procfs file
>>> - fix bad unlock on error recovery path
>> unfortunately the real patches doesn't have v3 which leads to confusion.
> Yeah, OK, I've updated my scripting for posting patches to include version
> in each posted patch :)
>
>> Just a note: in case this series cannot be applied for stable (5.15), we
>> need a second solution to fix the regression there.
> My plan is to backport the current series. It is not that invasive so it
> should be doable...
This would be great.
Btw i retested this version and i can confirm the procfs crash is fixed.
>
> Honza
prev parent reply other threads:[~2022-09-11 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 9:21 [PATCH 0/5 v3] ext4: Fix performance regression with mballoc Jan Kara
2022-09-08 9:21 ` [PATCH 1/5] ext4: Make mballoc try target group first even with mb_optimize_scan Jan Kara
2022-09-22 2:52 ` Theodore Ts'o
2022-09-22 9:15 ` Jan Kara
2022-09-26 9:11 ` Jan Kara
2022-09-26 17:32 ` Theodore Ts'o
2022-09-08 9:21 ` [PATCH 2/5] ext4: Avoid unnecessary spreading of allocations among groups Jan Kara
2022-09-08 9:21 ` [PATCH 3/5] ext4: Make directory inode spreading reflect flexbg size Jan Kara
2022-09-08 9:21 ` [PATCH 4/5] ext4: Use locality group preallocation for small closed files Jan Kara
2022-09-08 9:21 ` [PATCH 5/5] ext4: Use buckets for cr 1 block scan instead of rbtree Jan Kara
2022-09-09 6:12 ` Ritesh Harjani (IBM)
2022-09-08 10:36 ` [PATCH 0/5 v3] ext4: Fix performance regression with mballoc Stefan Wahren
2022-09-09 10:40 ` Jan Kara
2022-09-11 12:32 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eff8cbd-2d9c-0fb8-cfdb-31ce3534e466@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=harshadshirwadkar@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=regressions@leemhuis.info \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).