From: Daniel Tang <danielzgtg.opensource@gmail.com>
To: linux-ext4@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: [PATCH e2fsprogs] e2fsck: preen inline data no attr
Date: Wed, 04 Mar 2026 08:56:37 -0500 [thread overview]
Message-ID: <3188418.mvXUDI8C0e@daniel-desktop3> (raw)
I don't like being forcibly dropped into an emergency shell to truncate
pidfiles and other temporary files every time my tablet uncleanly shuts
down.
This seems safe. The only thing that should be erased is the size.
The removed inline data flag is remembered by the extent flag being
absent. There is no data to lose because there are no extents/blocks,
and the system.data attribute is already diagnosed missing.
Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com>
Link: https://github.com/tytso/e2fsprogs/pull/268
---
e2fsck/problem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index e433281f..e6f055f2 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -1170,7 +1170,7 @@ static struct e2fsck_problem problem_table[] = {
{ PR_1_INLINE_DATA_NO_ATTR,
/* xgettext:no-c-format */
N_("@i %i has INLINE_DATA_FL flag but @a not found. "),
- PROMPT_TRUNCATE, 0, 0, 0, 0 },
+ PROMPT_TRUNCATE, PR_PREEN_OK, 0, 0, 0 },
/* Special (device/socket/fifo) file (inode num) has extents
* or inline-data flag set */
--
2.51.0
next reply other threads:[~2026-03-04 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 13:56 Daniel Tang [this message]
2026-03-06 11:16 ` [PATCH e2fsprogs] e2fsck: preen inline data no attr Andreas Dilger
2026-03-06 15:51 ` Theodore Tso
2026-03-06 18:03 ` Daniel Tang
2026-03-06 22:23 ` Theodore Tso
2026-03-08 1:42 ` Daniel Tang
2026-03-08 5:04 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3188418.mvXUDI8C0e@daniel-desktop3 \
--to=danielzgtg.opensource@gmail.com \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox