From: Michael Forney <mforney@mforney.org>
To: Michael Forney <mforney@mforney.org>
Cc: Max Kellermann <max.kellermann@ionos.com>,
tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
brauner@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"
Date: Wed, 01 May 2024 13:04:40 -0700 [thread overview]
Message-ID: <3HNN4SNRB3DRD.39I8TYZWPN7S0@mforney.org> (raw)
In-Reply-To: <3MDOTS1CN0V39.3MG49L9WIC8VM@mforney.org>
Michael Forney <mforney@mforney.org> wrote:
> Max Kellermann <max.kellermann@ionos.com> wrote:
> > This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The
> > commit caused a regression because now the umask was applied to
> > symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> > has been fixed somewhere else already.
>
> Thanks, Max! I've verified that this fixes symlink modes for me,
> as well as the flatpak corruption error I was getting.
>
> > Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/
> > Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
>
> Tested-by: Michael Forney <mforney@mforney.org>
Just checking in on this. I'd really like to see this regression
fixed. It currently affects versions 6.5 through 6.9-rc6 as well
as all longterm releases.
next prev parent reply other threads:[~2024-05-01 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 14:29 [PATCH] Revert "ext4: apply umask if ACL support is disabled" Max Kellermann
2024-03-18 8:44 ` Christian Brauner
2024-03-25 0:22 ` Michael Forney
2024-05-01 20:04 ` Michael Forney [this message]
2024-05-02 22:26 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3HNN4SNRB3DRD.39I8TYZWPN7S0@mforney.org \
--to=mforney@mforney.org \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox