From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44A71161933 for ; Wed, 1 May 2024 20:04:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714593884; cv=none; b=tYSQ1tsZDPQl9fmcR3lJf+IHhWWiYyYndCnpqZ6jxMIBlpC4QGCG10eWKdgC+RSBdd5IdaOnyejPttFF9kCLq7qOimUtS6g96mBSijSIaJuRs4RJA3KhTHSxh+qaSvW7FaYO8VZ+gInjsgRvkL3ZOEZ90nr9RkWnAb0ZrL5skDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714593884; c=relaxed/simple; bh=Y0CK+l13J9hMie3EIzL6d+o5r8hwZWn1+a9iswKDlU0=; h=Date:To:Cc:Subject:From:References:In-Reply-To:Message-Id: MIME-Version:Content-Type; b=c9OYOl7hlact9h/5rDPrXmmvReoju1YsxqaXhod5LuyvkNC6InPn4W+KeGqm4TuA0KJ2Yx7wHjY5KDquS3jo1ns/HDra9JoQldbLQ79lU+tOfLMUNatQONq6ZnCg1XR+uJTabGekXDZPXocQYMfY9R9tBuWIZxtdy9EB8yHgG1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mforney.org; spf=pass smtp.mailfrom=mforney.org; dkim=pass (2048-bit key) header.d=mforney.org header.i=@mforney.org header.b=tyYUIcxU; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mforney.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mforney.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mforney.org header.i=@mforney.org header.b="tyYUIcxU" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6f103b541aeso6062330b3a.3 for ; Wed, 01 May 2024 13:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mforney.org; s=google; t=1714593881; x=1715198681; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:references:from:subject:cc:to:date:from:to:cc:subject :date:message-id:reply-to; bh=LnLzRmYxWQ0xWU0/l608+uhGlXGm+eTVFqBxpwekKbE=; b=tyYUIcxUEBGHk/Nc6F5mPDEUBSAY2Jfhg9Z7I8teI5bh4oV57lSz8traKiM9jYF0ft 4VNWQN+yRmmrqHJkdcSeANIKHkoaHYF0JhS0d+RheRoZM8SSMVwlVJBeAVYaWPAT7Mc8 5PdHok4l1f3bCMZiratLb203xL8YfCE7V3bCnZWsUyxMyBsI/+N45GeGvsiDIQ8bKrTZ lvyt8M+u7voCeO8QSuoM5ivCQ/geAORFzsAiCK+VtIURs+TMl+QUe2GWxYNjwIbTuKPp xn3tqJPNxyisT2MKFdrCL2tr503LXhXZVV9p97Iy/hBHq5RZTbCY3QOBvtiFLuzjLUR9 jMvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714593881; x=1715198681; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:references:from:subject:cc:to:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LnLzRmYxWQ0xWU0/l608+uhGlXGm+eTVFqBxpwekKbE=; b=waYg4rOBkeK2pnWtLdQCtiF/VoCB41sPp3Bh1prTId4jqH8PTqdI30doha4V3RpRe2 lipux5PFTCveb1IXehK3iRgQIyuOuCtQ5N81d0shmtIIoSMCgt1YPCNRaXdF4CU3is9t YTxmznpMsGNBEhOH1ks6SMGZIXB6UpAN5Su3JpocRxZnLDsty1XeaYgPDVjGp1yTbEPX Cbnu/2xEw8Vc0xv+GrBDEPuhtnbDkYarD0mJImk4HxvmaUzz7d5LIWF0YRkuTYKm2/3j kxi9uWmpbefTlV4EiWmfNoyl9h3P8H1OliJE2pRm6fbnHYPGkBB4SEK4n04cYdMJQjUi 2FWQ== X-Forwarded-Encrypted: i=1; AJvYcCUmQdSTetkq5AhTNBGGHqUBgsLuDZay/jD2xo3w/eJImOfrFyU5MJ4QLM2pR2FZIRL66Zg7DUks3OvqHjyD8ndunFIRuQA/Lh6ATw== X-Gm-Message-State: AOJu0Yy+QrFpw9JNj5S++3Nlb9uB40WpN4qZQHyy066M+6KlWW2+OF0X tF6+iddjG8xapWyp0mtZeoZqbWEnKoK/qTHV9FazyvghpqIhitf5tbtJbBx0zZQ= X-Google-Smtp-Source: AGHT+IGuIoUPm+qDmwyr9OZHb1tPZ+GL11t/9KEIjx32bGz5VlOlicXDFu+IUmeGYhOeZE8wgQAj4A== X-Received: by 2002:a05:6a00:b44:b0:6f3:e6ac:1a3f with SMTP id p4-20020a056a000b4400b006f3e6ac1a3fmr4013945pfo.11.1714593881446; Wed, 01 May 2024 13:04:41 -0700 (PDT) Received: from localhost ([2601:647:6400:20b0:16dd:a9ff:fee7:6b79]) by smtp.gmail.com with ESMTPSA id s23-20020a62e717000000b006ed045e3a70sm22984102pfh.25.2024.05.01.13.04.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 May 2024 13:04:40 -0700 (PDT) Date: Wed, 01 May 2024 13:04:40 -0700 To: Michael Forney Cc: Max Kellermann , tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, brauner@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled" From: Michael Forney References: <20240315142956.2420360-1-max.kellermann@ionos.com> <3MDOTS1CN0V39.3MG49L9WIC8VM@mforney.org> In-Reply-To: <3MDOTS1CN0V39.3MG49L9WIC8VM@mforney.org> Message-Id: <3HNN4SNRB3DRD.39I8TYZWPN7S0@mforney.org> User-Agent: mblaze/1.2 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Michael Forney wrote: > Max Kellermann wrote: > > This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The > > commit caused a regression because now the umask was applied to > > symlinks and the fix is unnecessary because the umask/O_TMPFILE bug > > has been fixed somewhere else already. >=20 > Thanks, Max! I've verified that this fixes symlink modes for me, > as well as the flatpak corruption error I was getting. >=20 > > Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney= .org/ > > Signed-off-by: Max Kellermann >=20 > Tested-by: Michael Forney Just checking in on this. I'd really like to see this regression fixed. It currently affects versions 6.5 through 6.9-rc6 as well as all longterm releases.