Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Zhang Yi <yizhang089@gmail.com>
To: Andreas Dilger <adilger@dilger.ca>,
	"Korber, Markus" <markus.korber@anton-paar.com>
Cc: Theodore Tso <tytso@mit.edu>, Gabriele Moabiti <gabmoa@gmail.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: ext4 data=journal deprecation: long-standing industrial use case
Date: Fri, 23 Oct 2026 09:31:32 +0800	[thread overview]
Message-ID: <3e774e32-fa5c-43ad-bc2a-c6d29f7ec7df@gmail.com> (raw)
In-Reply-To: <8B27CFE7-E4AD-4679-B772-6473C3849964@dilger.ca>

On 10/23/2026 7:22 AM, Andreas Dilger wrote:
> On Oct 19, 2026, at 22:18, Korber, Markus <markus.korber@anton-paar.com> wrote:
>>
>> On Oct 19, 2026, Andreas Dilger wrote:
>>
>>> are you running with delalloc disabled when testing ordered mode?
>>> That might be the source of NULs in recently written files.
>>
>> No, we did not explicitly disable delayed allocation.
>>
>> The data=ordered tests were run with:
>>
>>    data=ordered,commit=2,noatime,errors=continue
>>
>> so delayed allocation should have been enabled with the normal ext4
>> default.
> 
> What I mean is that if you *do* disable delalloc then this might stop
> the appearance of NULs at the end of a file after a crash.  The normal
> "ordered" mode writes should sync data to the filesystem before the
> size is updated in the inode, but delalloc does not do that.
> 
> Cheers, Andreas

I think this is caused by the default dioread_nolock behavior. Once
dioread_nolock is enabled, the extents allocated during writeback
are unwritten, so ordered mode doesn't take effect, and the
transaction that updates i_disksize may hit the disk before the
data I/O is persisted.

Cheers,
Yi.

  reply	other threads:[~2026-10-23  1:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAbJaeALOrZwWs++mz9Wv0pfvyDoHmfzPKyVHR0v6TwnzLkYGw@mail.gmail.com>
2026-10-12 18:53 ` ext4 data=journal deprecation: long-standing industrial use case Theodore Tso
2026-10-14 10:51   ` Andreas Dilger
2026-10-19  8:51   ` Korber, Markus
2026-10-19 12:38     ` Zhang Yi
2026-10-20  1:50     ` Andreas Dilger
2026-10-20  4:18       ` Korber, Markus
2026-10-22 23:22         ` Andreas Dilger
2026-10-23  1:31           ` Zhang Yi [this message]
2026-10-12 14:50 Gabriele Moabiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e774e32-fa5c-43ad-bc2a-c6d29f7ec7df@gmail.com \
    --to=yizhang089@gmail.com \
    --cc=adilger@dilger.ca \
    --cc=gabmoa@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=markus.korber@anton-paar.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox