linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>, "Jan Kara" <jack@suse.cz>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
	linux-kernel@vger.kernel.org,
	Josh Triplett <josh@joshtriplett.org>,
	kvm@vger.kernel.org
Subject: Re: kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!!
Date: Wed, 26 Apr 2017 16:29:55 +0200	[thread overview]
Message-ID: <43412479-18a3-0c55-3d32-97c15ee5fe87@redhat.com> (raw)
In-Reply-To: <20170426141858.GA26972@potion>



On 26/04/2017 16:18, Radim Krčmář wrote:
>> OK, but looking at the stack trace, this has nothing to do with ext4. The
>> problem seems to be in KVM - relevant CCs added.
> The path begins with async_page_fault interrupt gate and the hardware
> should clear the interrupt flag before executing it.  I don't see a
> change that would break the assumption that interrupts are disabled ...

native_safe_halt enables interrupts.  I think this is it:

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 14f65a5f938e..2a7835932b71 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -161,8 +161,8 @@ void kvm_async_pf_task_wait(u32 token)
 			 */
 			rcu_irq_exit();
 			native_safe_halt();
-			rcu_irq_enter();
 			local_irq_disable();
+			rcu_irq_enter();
 		}
 	}
 	if (!n.halted)

Paolo

  reply	other threads:[~2017-04-26 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 20:13 kernel/rcu/tree.c:1031 rcu_irq_enter() invoked with irqs enabled!!!! Ross Zwisler
2017-04-25 20:28 ` Paul E. McKenney
2017-04-26  7:16   ` Jan Kara
2017-04-26 14:18     ` Radim Krčmář
2017-04-26 14:29       ` Paolo Bonzini [this message]
2017-04-26 14:39         ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43412479-18a3-0c55-3d32-97c15ee5fe87@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jack@suse.cz \
    --cc=josh@joshtriplett.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rkrcmar@redhat.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).