Re: ext4 kernel patches against linux-2.6.18-rc7-mm1

[Eric Sandeen <esandeen@redhat.com>]

Eric Sandeen wrote:
> Dave Kleikamp wrote:
> 
>> # From Mingming Cao
>> sector_t-jbd2.patch
> 
> I think this one needs to address the first, last variables in
> journal_fail_superblock():
> 
>  static int journal_reset(journal_t *journal)
>  {
>         journal_superblock_t *sb = journal->j_superblock;
> -       unsigned int first, last;
> +       sector_t first, last;
> 
>         first = be32_to_cpu(sb->s_first);
>         last = be32_to_cpu(sb->s_maxlen);
> 
> (and then later change that back to unsigned long long, in the spirit of
> the patch series)

Hm, and looking further, I think this change:

 journal_t * jbd2_journal_init_dev(struct block_device *bdev,
                        struct block_device *fs_dev,
-                       int start, int len, int blocksize)
+                       sector_t start, int len, int blocksize)

is unnecessary; this is initializing the journal on an external device,
and start is in the first few blocks of the disk:

        sb_block = EXT3_MIN_BLOCK_SIZE / blocksize;
        start = sb_block + 1;

and len is also constrained by the maximum log size.

-Eric