From: Mingming Cao <cmm@us.ibm.com>
To: Alex Tomas <alex@clusterfs.com>
Cc: "Amit K. Arora" <aarora@linux.vnet.ibm.com>,
linux-ext4@vger.kernel.org, suparna@in.ibm.com
Subject: Re: [PATCH 1/1] Extent overlap bugfix in ext4
Date: Thu, 04 Jan 2007 10:23:13 -0800 [thread overview]
Message-ID: <459D4611.3090707@us.ibm.com> (raw)
In-Reply-To: <m3hcv7f6r2.fsf@bzzz.home.net>
Alex Tomas wrote:
>>>>>>Mingming Cao (MC) writes:
>
>
> MC> But the bug Amit pointed here is unrelated to the code convert
> MC> uninitialized blocks to initialized ones. Rather, it's related to do
> MC> multiple block allocation across on a window with parts already have
> MC> blocks allocated. Without the check, the current code just simply
> MC> allocate the requested extent and insert it into the tree which might
> MC> overlap with existing extent.
>
> correct. thanks for catching. in delayed allocation patch
> get_blocks() isn't used and ext4_ext_walk_space() works
> right in this case.
>
Yep, I realized that yesterday. That explains we never see this overlap
problem when we testing extent+delalloc+mballoc last year.
ext4_ext_walk_space did almost all the overlap check. I think we
could reuse that code.
Mingming
> thanks, Alex
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-01-04 18:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 9:09 [PATCH 1/1] Extent overlap bugfix in ext4 Amit K. Arora
2007-01-02 9:25 ` Alex Tomas
2007-01-02 9:47 ` Amit K. Arora
2007-01-03 9:44 ` Alex Tomas
2007-01-03 18:07 ` Mingming Cao
2007-01-04 8:13 ` Amit K. Arora
2007-01-04 10:04 ` Alex Tomas
2007-01-04 18:23 ` Mingming Cao [this message]
2007-01-03 1:35 ` Mingming Cao
2007-01-03 6:06 ` Amit K. Arora
2007-01-04 8:54 ` [PATCH 1/1 version2] " Amit K. Arora
2007-01-04 10:25 ` Alex Tomas
2007-01-04 11:16 ` Amit K. Arora
2007-01-04 10:39 ` Alex Tomas
2007-01-04 11:27 ` Amit K. Arora
2007-01-04 11:37 ` Alex Tomas
2007-01-04 17:23 ` Amit K. Arora
2007-01-04 18:50 ` Mingming Cao
2007-01-04 19:19 ` Alex Tomas
2007-01-05 12:13 ` Amit K. Arora
2007-01-09 5:51 ` [PATCH 1/1 version3] " Amit K. Arora
2007-01-04 19:03 ` [PATCH 1/1 version2] " Alex Tomas
2007-01-04 19:47 ` Mingming Cao
2007-01-05 6:18 ` Amit K. Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459D4611.3090707@us.ibm.com \
--to=cmm@us.ibm.com \
--cc=aarora@linux.vnet.ibm.com \
--cc=alex@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).