From: Eric Sandeen <sandeen@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Alex Tomas <alex@clusterfs.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: booked-page-flag.patch
Date: Thu, 15 Feb 2007 09:18:34 -0800 [thread overview]
Message-ID: <45D495EA.3060200@redhat.com> (raw)
In-Reply-To: <20070215004504.023a90f0.akpm@linux-foundation.org>
Andrew Morton wrote:
> Sorry, we're seriously, seriously, seriously short on flags in the page
> struct and this patch is going to need one heck of a good case for it to be
> acceptable.
This was for the delayed allocation patchset, right; and by managing
this at the page level that means we can't do this for block size < page
size, I think...
There are already buffer head flags for delalloc (block to be allocated
on flush) and unwritten (actual block allocated to a file but not yet
written) in the vfs - shouldn't we be looking at using those?
Unless there is a clear path from this patchset to one that supports
blocks < page, I'm hesitant about it... but I know I'm being a bit of an
armchair quarterback here, and I'll try to set aside some time to give
this a better look.
Thanks,
-Eric
next prev parent reply other threads:[~2007-02-15 17:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 8:45 booked-page-flag.patch Andrew Morton
2007-02-15 14:03 ` booked-page-flag.patch Alex Tomas
2007-02-15 17:18 ` Eric Sandeen [this message]
2007-02-15 17:30 ` booked-page-flag.patch Alex Tomas
2007-02-15 20:56 ` booked-page-flag.patch Andrew Morton
2007-02-15 21:07 ` booked-page-flag.patch Alex Tomas
2007-02-15 23:23 ` booked-page-flag.patch Andrew Morton
2007-02-16 7:30 ` booked-page-flag.patch Alex Tomas
2007-02-16 7:46 ` booked-page-flag.patch Andrew Morton
2007-02-16 7:56 ` booked-page-flag.patch Alex Tomas
2007-02-16 8:06 ` booked-page-flag.patch Andrew Morton
2007-02-16 12:14 ` booked-page-flag.patch Andreas Dilger
2007-02-16 16:02 ` booked-page-flag.patch Dave Kleikamp
2007-02-16 15:03 ` booked-page-flag.patch Theodore Tso
2007-02-15 20:21 ` booked-page-flag.patch Andrew Morton
2007-02-16 12:17 ` booked-page-flag.patch Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D495EA.3060200@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).