public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasily Averin <vvs@sw.ru>
To: linux-ext4@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Tweedie <sct@redhat.com>,
	Andreas Dilger <adilger@clusterfs.com>,
	devel@openvz.org
Subject: dead code: EXT3_IOC_WAIT_FOR_READONLY?
Date: Fri, 16 Mar 2007 14:16:28 +0300	[thread overview]
Message-ID: <45FA7C8C.2010904@sw.ru> (raw)

Hi all,

I've found some strange ext3 ioctl under CONFIG_JBD_DEBUG:
EXT3_IOC_WAIT_FOR_READONLY.

I had DEBUG_SPINLOCK enabled and my kernel was crashed on wait-for-readonly.c
test from ext3-tools because ioctl handler tries to use uninitialized
EXT3_SB(sb)->ro_wait_queue and waits EXT3_SB(sb)->turn_ro_timer that nobody uses
in kernel.

I do not understand the function of this ioctl and believe this code is dead
long time ago. From my POV it makes sense to remove it from kernel instead of
fixing it. Has somebody any objections?

Thank you,
	Vasily Averin

             reply	other threads:[~2007-03-16 11:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 11:16 Vasily Averin [this message]
2007-03-16 12:03 ` dead code: EXT3_IOC_WAIT_FOR_READONLY? Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FA7C8C.2010904@sw.ru \
    --to=vvs@sw.ru \
    --cc=adilger@clusterfs.com \
    --cc=akpm@linux-foundation.org \
    --cc=devel@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox