From: Eric Sandeen <sandeen@redhat.com>
To: Phillip Susi <psusi@cfl.rr.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Add a norecovery option to ext3/4?
Date: Mon, 09 Apr 2007 12:21:15 -0500 [thread overview]
Message-ID: <461A760B.1040103@redhat.com> (raw)
In-Reply-To: <461A5F13.7040705@cfl.rr.com>
Phillip Susi wrote:
> Samuel Thibault wrote:
>> Hi,
>>
>> Distribution installers usually try to probe OSes for building a suited
>> grub menu. Unfortunately, mounting an ext3 partition, even in read-only
>> mode, does perform some operations on the filesystem (log recovery).
>> This is not a good idea since it may silently garbage data. XFS has a
>> norecovery option that allows to disable that, I'd say ext3/4 should
>> have it too.
>
> When the filesystem is told to mount the disk read only, that means it
> should not write to it.
It means the filesystem should not be writeable when it is mounted.
This is not the same as saying that the filesystem itself should do no
IO in the course of making that read-only mount available.
> The fact that ext3 goes ahead and does anyway
> is a bug and should be fixed. There is no need for a norecovery option,
> because read only is a sufficient directive to tell the filesystem not
> to write to the disk.
I respectfully disagree, see above.
> As someone else pointed out, this behavior causes havoc if you hibernate
> a system and then boot up another system which mounts the disk of the
> hibernated system.
In that case you are mounting the same filesystem uner 2 different
operating systems simultaneously, which is, and always has been, a
recipe for disaster. Flagging the fs as "mounted already" would
probably be a better solution, though it's harder than it sounds at
first glance.
> Under all conditions it should be safe to mount a
> disk read only, but here it is not because the journal playback trashes
> the disk out from under the hibernated system.
Under all conditions it should be safe to mount a read-only block
device, but that is not the same as mounting a filesystem read-only.
-Eric
next prev parent reply other threads:[~2007-04-09 17:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 0:05 Add a norecovery option to ext3/4? Samuel Thibault
2007-04-09 3:24 ` Eric Sandeen
2007-04-09 3:31 ` Samuel Thibault
2007-04-09 3:42 ` Eric Sandeen
2007-04-09 14:00 ` Theodore Tso
2007-04-09 4:29 ` Brad Campbell
2007-04-09 10:14 ` Andreas Dilger
2007-04-09 13:42 ` Valdis.Kletnieks
2007-04-09 16:37 ` Jan Engelhardt
2007-04-11 20:06 ` Pavel Machek
2007-04-09 15:43 ` Phillip Susi
2007-04-09 16:20 ` Kyle Moffett
2007-04-09 17:21 ` Eric Sandeen [this message]
2007-04-10 7:22 ` Jörn Engel
2007-04-10 11:27 ` Theodore Tso
2007-04-10 12:08 ` Jörn Engel
2007-04-10 16:44 ` Matt Mackall
2007-04-10 18:54 ` Phillip Susi
2007-04-10 19:18 ` Eric Sandeen
2007-04-10 22:04 ` Phillip Susi
2007-04-11 20:09 ` Bill Davidsen
2007-04-12 13:54 ` Benny Amorsen
2007-04-15 18:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461A760B.1040103@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psusi@cfl.rr.com \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).