From: Eric Sandeen <sandeen@redhat.com>
To: cmm@us.ibm.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fix ext2 allocator overflows above 31 bit blocks
Date: Fri, 20 Apr 2007 19:43:39 -0500 [thread overview]
Message-ID: <46295E3B.2070503@redhat.com> (raw)
In-Reply-To: <1177115236.3778.23.camel@dyn9047017103.beaverton.ibm.com>
Mingming Cao wrote:
> On Fri, 2007-04-20 at 18:14 -0500, Eric Sandeen wrote:
>> It's a bug, today.
>
> They are fixed in mm tree, as part of the patches which backports ext3
> block reservation code to ext2. filesystem block numbers are all
> ext2_fsblk_t type(i.e. unsigned long)(see ext2_new_blocks()). Maybe need
> a round of thorough review to see if anything left, but I think what in
> mm tree looks good.
Oh... oops. I didn't think to check mm, didn't expect to find those
changes on ext2. Ok, I will double-check that against what I did.
> And those patches in mm tree also backports the ext3 best-effort
> allocates multiple blocks code (allocate multiple blocks within the
> block reservation window as much as possible), FYI.
Ok, thanks Mingming!
-Eric
prev parent reply other threads:[~2007-04-21 0:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 17:10 [PATCH] fix ext2 allocator overflows above 31 bit blocks Eric Sandeen
2007-04-20 23:02 ` Andreas Dilger
2007-04-20 23:14 ` Eric Sandeen
2007-04-21 0:27 ` Mingming Cao
2007-04-21 0:43 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46295E3B.2070503@redhat.com \
--to=sandeen@redhat.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).