From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] Accomodate 32-bit uid/guid values in e2fsprogs
Date: Tue, 08 May 2007 00:05:34 -0500 [thread overview]
Message-ID: <4640051E.4040703@redhat.com> (raw)
In-Reply-To: <20070508042813.GD10940@thunk.org>
Theodore Tso wrote:
> On Mon, May 07, 2007 at 12:10:37PM -0500, Eric Sandeen wrote:
>> e2fsprogs doesn't handle large (> 16 bit) UID/GID...
>
> Applied, with one correction:
>
>> --- e2fsprogs-hg.orig/misc/mke2fs.c
>> +++ e2fsprogs-hg/misc/mke2fs.c
>> @@ -492,9 +494,14 @@ static void create_root_dir(ext2_filsys
>> _("while reading root inode"));
>> exit(1);
>> }
>> - inode.i_uid = getuid();
>> - if (inode.i_uid)
>> - inode.i_gid = getgid();
>> + uid = getuid();
>> + inode.i_uid = uid;
>> + inode.i_uid_high = uid >> 16;
>> + if (inode.i_uid) {
> ^^^^^^^^^^^
>
> This should be "uid" instead. Otherwise, the gid won't be set if the
> uid is a multiple of 65536.
>
> - Ted
Doh... dumb mistake. nice catch. thanks.
-Eric
prev parent reply other threads:[~2007-05-08 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 17:10 [PATCH] Accomodate 32-bit uid/guid values in e2fsprogs Eric Sandeen
2007-05-08 4:28 ` Theodore Tso
2007-05-08 5:05 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4640051E.4040703@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).