linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Valerie Clement <valerie.clement@bull.net>
Cc: "Jose R. Santos" <jrs@us.ibm.com>, linux-ext4@vger.kernel.org
Subject: Re: Creating a >32bit blocks filesystem.
Date: Wed, 09 May 2007 12:18:37 -0500	[thread overview]
Message-ID: <4642026D.3040401@redhat.com> (raw)
In-Reply-To: <463B4A1B.4070201@bull.net>

Valerie Clement wrote:

> Get the new version of e2fsprogs at
> ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/e2fsprogs-interim/e2fsprogs-1.39-tyt3
> and apply the patchset in attachment.
> 
> Hope this helps,
>     Valérie

Valérie, this looks a bit odd in 02_use_64bit_io, in debugfs.c:

@@ -149,13 +149,13 @@ void do_open_filesys(int argc, char **ar
                        data_filename = optarg;
                        break;

                case 'b':
-                       blocksize = parse_ulong(optarg, argv[0],
+                       blocksize = parse_ullong(optarg, argv[0],
                                                "block size", &err);

and same for similar code in main() in debugfs.c.

Surely the block *size* doesn't need to be 64 bits :)  I guess that got
accidentally inherited from e2fsprogs-1.39 where blocksize is type
blk_t, which turned into 64 bits now... I think "int" will be fine.  :)

Thanks,
-Eric

      parent reply	other threads:[~2007-05-09 17:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03 19:08 Creating a >32bit blocks filesystem Jose R. Santos
2007-05-04 14:58 ` Valerie Clement
2007-05-07 16:19   ` Jose R. Santos
2007-05-07 18:36     ` Jose R. Santos
2007-05-09 12:16     ` Valerie Clement
2007-05-09 13:55       ` Jose R. Santos
2007-05-09 14:57         ` Valerie Clement
2007-05-09 15:21           ` Eric Sandeen
2007-05-09 16:34             ` Jose R. Santos
2007-05-09 17:02               ` Eric Sandeen
2007-05-09 15:29           ` Jose R. Santos
2007-05-09 16:15           ` Andreas Dilger
2007-05-09 17:18   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4642026D.3040401@redhat.com \
    --to=sandeen@redhat.com \
    --cc=jrs@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=valerie.clement@bull.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).