From: Eric Sandeen <sandeen@redhat.com>
To: Karsten Hopp <karsten@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Patch to support LUKS UUIDs in libblkid
Date: Tue, 05 Jun 2007 09:20:23 -0500 [thread overview]
Message-ID: <46657127.1050608@redhat.com> (raw)
In-Reply-To: <4665479E.2060707@redhat.com>
Karsten Hopp wrote:
> Hello,
>
> I've already posted this at the e2fsprogs sourceforge site, but our
> e2fsprogs maintainer
> suggested that I should post it here as well for a review:
>
>
> Attached is a patch to add cryptsetup-luks UUID detection in libblkid.so
> This is required when we want to use UUIDs instead of hardcoded device
> names for
> encrypted partitions.
Hi Karsten, in the patch you posted, need to remove the
__BLKID_ATTR((unused)) from:
+static int probe_luks(struct blkid_probe *probe,
+ struct blkid_magic *id __BLKID_ATTR((unused)),
+ unsigned char *buf)
+{
since id is being used now.
-Eric
next prev parent reply other threads:[~2007-06-05 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 11:23 Patch to support LUKS UUIDs in libblkid Karsten Hopp
2007-06-05 14:20 ` Eric Sandeen [this message]
2007-06-05 23:17 ` Andreas Dilger
2007-06-08 15:36 ` Theodore Tso
2007-06-11 11:51 ` Karsten Hopp
2007-06-12 23:40 ` Theodore Tso
2007-06-13 11:00 ` Karsten Hopp
2007-06-21 17:56 ` Theodore Tso
2007-07-03 9:19 ` Karsten Hopp
2007-07-03 15:57 ` Eric Sandeen
[not found] ` <46964694.7000707@redhat.com>
2007-07-23 15:00 ` Karsten Hopp
2007-07-23 16:19 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46657127.1050608@redhat.com \
--to=sandeen@redhat.com \
--cc=karsten@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).