Re: [RFC][PATCH 0/12] e2fsprogs: add 64-bit support

[Valerie Clement <valerie.clement@bull.net>]

Andreas Dilger wrote:
> On Jun 11, 2007  18:41 +0200, Valerie Clement wrote:
>> This patchset is also not complete:
>> TODO:
>>   - update code under ext2ed/,
> 
> This code should just be removed entirely.  It is dangerous to use, and
> by including it in e2fsprogs it lends a false sense of credibility to
> the code.  Hopefully most of the functionality here has been incorporated
> into debugfs?
> 
OK.

>> Code compiled, booted and briefly tested on a 20TB device (mkfs, 
>> debugfs, e2fsck, dumpe2fs, filefrag tested)
>> Some non-regression tests also done on ext3 filesystems when compiling 
>> code without _EXT4FS_ option.
> 
> Did you run the "make check" tests?  We've found these invaluable for
> catching regressions.  Ideally there would also be some test cases
> for this support using "lazy_bg", a script to generate the filesystem,
> and conditional upon being able to create sparse files that big.
> 
I missed to mention that some changes have to be done under tests/ too.
Without changes, "make check" fails.

     Valérie