ext4 patch queue updated

ext4 patch queue updated

[Mingming Cao]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Just updated the ext4 patch queue

http://repo.or.cz/w/ext4-patch-queue

Changes:

Added these three patches from Jose Santos:
ext4_set_jbd2_64bit_feature.patch
jbd2_config_jbd2_debug_fix.patch
jbd2_move_jbd2_debug_to_debugfs.patch

Reordered the series, move 
jbd-stats-through-procfs and ext4_remove_subdirs_limit.patch before
delayed allocation patches


Run checkpatch.pl http://lwn.net/Articles/237451/
I fixed coding style issues for most patches by hand except the delayed
allocation patch ext4-delayed-allocation.patch.  That need a bit more
work and requires someone family with the code better. Alex, can you
help on this? Attached is the checkpatch.pl output, thanks.


Mingming



[-- Attachment #2: a.out --]
[-- Type: text/plain, Size: 2741 bytes --]

printk() should include KERN_ facility level
#275: FILE: fs/ext4/writeback.c:73:
+#define wb_debug(fmt, a...)	printk(fmt, ##a);

do not use assignment in condition
#338: FILE: fs/ext4/writeback.c:136:
+		while (!bio && (nr_vecs /= 2))

printk() should include KERN_ facility level
#826: FILE: fs/ext4/writeback.c:624:
+			printk("no mem for ext4_wb_pages!\n");

#if 0 -- if this code redundant remove it
#946: FILE: fs/ext4/writeback.c:744:
+#if 0

line over 80 characters
#948: FILE: fs/ext4/writeback.c:746:
+					printk("#%u: wow! short extent %d for flush on #%lu\n",

printk() should include KERN_ facility level
#948: FILE: fs/ext4/writeback.c:746:
+					printk("#%u: wow! short extent %d for flush on #%lu\n",

line over 80 characters
#949: FILE: fs/ext4/writeback.c:747:
+						(unsigned) current->pid, wc.len, inode->i_ino);

line over 80 characters
#950: FILE: fs/ext4/writeback.c:748:
+					printk("#%u: done = %d, nr_to_write %ld, sync = %d\n",

printk() should include KERN_ facility level
#950: FILE: fs/ext4/writeback.c:748:
+					printk("#%u: done = %d, nr_to_write %ld, sync = %d\n",

line over 80 characters
#951: FILE: fs/ext4/writeback.c:749:
+						(unsigned) current->pid, done, wbc->nr_to_write,

printk() should include KERN_ facility level
#953: FILE: fs/ext4/writeback.c:751:
+					printk("#%u: written %d, extents %d\n",

line over 80 characters
#954: FILE: fs/ext4/writeback.c:752:
+						(unsigned) current->pid, written, extents);

printk() should include KERN_ facility level
#955: FILE: fs/ext4/writeback.c:753:
+					printk("#%u: cur %lu, prev %lu\n",

#if 0 -- if this code redundant remove it
#985: FILE: fs/ext4/writeback.c:783:
+#if 0

line over 80 characters
#991: FILE: fs/ext4/writeback.c:789:
+				atomic_inc(&EXT4_SB(inode->i_sb)->s_wb_congested);

printk() should include KERN_ facility level
#1370: FILE: fs/ext4/writeback.c:1168:
+	printk("EXT4-fs: writeback: %d blocks %d extents in %d reqs (%d ave)\n",

line over 80 characters
#1375: FILE: fs/ext4/writeback.c:1173:
+	printk("EXT4-fs: writeback: %d nr_to_write, %d congestions, %d singles\n",

printk() should include KERN_ facility level
#1375: FILE: fs/ext4/writeback.c:1173:
+	printk("EXT4-fs: writeback: %d nr_to_write, %d congestions, %d singles\n",

printk() should include KERN_ facility level
#1379: FILE: fs/ext4/writeback.c:1177:
+	printk("EXT4-fs: writeback: %d collisions, %d single-page collisions\n",

printk() should include KERN_ facility level
#1382: FILE: fs/ext4/writeback.c:1180:
+	printk("EXT4-fs: writeback: %d allocated, %d dropped\n",

Missing Signed-off-by: line(s)
Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Re: ext4 patch queue updated

[Alex Tomas]

OK

Mingming Cao wrote:
> Run checkpatch.pl http://lwn.net/Articles/237451/
> I fixed coding style issues for most patches by hand except the delayed
> allocation patch ext4-delayed-allocation.patch.  That need a bit more
> work and requires someone family with the code better. Alex, can you
> help on this? Attached is the checkpatch.pl output, thanks.

ext4 patch queue rebased to linux2.6.22-rc5

[Mingming Cao]

http://repo.or.cz/w/ext4-patch-queue.git

diff --git a/series b/series


index d68345c..766f3eb 100644 (file)


--- a/series

+++ b/series

@@ -1,4 +1,4 @@

-# Rebased the patches to 2.6.22-rc4

+# Rebased the patches to 2.6.22-rc5

 

 # Add mount option to turn off extents

 ext4_noextent_mount_opt.patch

@@ -60,6 +60,14 @@ jbd-stats-through-procfs

 # Remove 32000 subdirs limit. 

 ext4_remove_subdirs_limit.patch

 

+# Add unused inode watermark and checksum to blockgroup descriptors

+ext4_uninit_blockgroup.patch

+# need sign off

+update-uninit.patch

+

+# Need sing off and fix coding style

+# Add journal checksums

+ext4-journal_chksum-2.6.20.patch

 ##############################################################

 # Unstable patches

 # Note: still lots of outstanding comments from linux-ext4 list, 12/2006

@@ -81,3 +89,8 @@ ext4_nodelalloc_mount_opt.patch

 

 # Fix error returned from ext4_reserve_global

 ext4_reserve_global_return_error_fix.patch

+

+#Fix invariant checking in ext4_rebalance_reservation()

+#Missing signed offs

+ext4_rebalance_reservation_invariant_checking_fix.patch

+ext4_delalloc_setpageprivate_fix.patch

ext4 patch queue updated

[Mingming Cao]

I have updated ext4 patch queue.  The updated ext4 patch queue includes
updated patches from Kalpak, Jose, and me.  It now addresses most of
review comments from Andrew, including checkpatch.pl complains, add
"diffstat"  etc. Also I noticed Amit has updated fallocate() patch
series as well.

The patches that still need more attentions are:

ext4-journal_chksum-2.6.20.patch
jbd-stats-through-procfs_fix.patch
and inode version patch series


Thanks,
Mingming Cao

ext4 patch queue updated

[Mingming Cao]

Hi Ted,

The ext4 patch queue has been updated with updates to address latest
review comments.  http://repo.or.cz/w/ext4-patch-queue.git

The series is being reordered: the patches still has outstanding
comments are moved to the end of the series. Per our discussion on
Monday, tThose patches are ready for submission are

# Rebased the patches to 2.6.22

# fallocate() syscall patches and ext4 fallocate() implementation
# Missing manpages
#ext4-fallocate-1-man-page
ext4-fallocate-2-syscall_i386_amd64_ppc
ext4-fallocate-3-ext4_support
ext4-fallocate-4-uninit_write_support
ext4-fallocate-5-new-ondisk-format

# Add mount option to turn off extents
ext4_noextent_mount_opt.patch

# Mounted ext4dev fs with extents by default for testing purpose,
# for Ext4 product release, extents mount option
# will be turn on only if the fs has EXTENTS feature on
ext4_extents_on_by_default.patch

# Propagate inode flags
ext4-propagate_flags.patch

# Add extent sanity checks
ext4-extent-sanity-checks.patch

# Bug fix:set 64bit JBD2 feature on >32bit ext4 fs
ext4_set_jbd2_64bit_feature.patch

# Fix: Rename CONFIG_JBD_DEBUG to CONFIG_JBD2_DEBUG
jbd2_config_jbd2_debug_fix.patch

# Export jbd2-debug via debugfs
jbd2_move_jbd2_debug_to_debugfs.patch

# Nanosecond timestamp support
ext4-nanosecond-patch
ext4_negative_timestamp_handle_fix.patch

# New patch to expand inode i_extra_isize to support features
# in high part of inode (>128 bytes)
ext4_expand_inode_extra_isize.patch

# Remove 32000 subdirs limit. 
ext4_remove_subdirs_limit.patch

# Various Cleanups
ext4-zero_user_page.patch
is_power_of_2-ext4-superc.patch
ext4-remove-extra-is_rdonly-check.patch
ext4_extent_compilation_fixes.patch
ext4_extent_macros_cleanup.patch

#JBD->JBD2 naming cleanups