* Re: performance testing [not found] ` <4680CE9B.1030602@bull.net> @ 2007-06-26 9:48 ` Valerie Clement 2007-06-26 10:36 ` Girish Shilamkar 0 siblings, 1 reply; 3+ messages in thread From: Valerie Clement @ 2007-06-26 9:48 UTC (permalink / raw) To: Valerie Clement, Alex Tomas, Andreas Dilger; +Cc: ext4 development Valerie Clement wrote: > Alex Tomas wrote: >> Jean noel Cordenner wrote: >>> The last patch queue concerns the 2.6.22-rc4 kernel, so we took the >>> previous ext4 patch queue including the modifications suggested by >>> dmitriy: >>> http://article.gmane.org/gmane.comp.file-systems.ext4/2291 >>> This solve the oops problem but after a while, the system hangs. We are >>> still trying to find where the bug is. >>> When we remove all the patches until booked-page-flag.patch in the >>> series, the system still hangs. When using another filesystem, or >>> whithout any patches it works. >> >> any details? backtraces? dmesg? > > We are trying to get some traces, but with 2.6.22-rc5 and 2.6.22-rc6 > kernels, the serial console isn't working on our systems (x86_64), the > magic SysRq keys either. Strange... > > When the system hangs, no messages are logged. > It seems that the hangs only occur with ext4 FS when applying the > patches of the current git tree. > We are trying now to find which patch is faulty. > > Valérie > It seems that the faulty patch is "ext4-journal_chksum-2.6.20.patch". Looking at the patch, I think the following change is not correct: @@ -116,21 +120,36 @@ static int journal_write_commit_record(j bh = jh2bh(descriptor); - /* AKPM: buglet - add `i' to tmp! */ for (i = 0; i < bh->b_size; i += 512) { - journal_header_t *tmp = (journal_header_t*)bh->b_data; + struct commit_header *tmp = (struct commit_header*)bh->b_data + + i; Shouldn't it be : struct commit_header *tmp = (struct commit_header*)(bh->b_data + i); Valérie ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: performance testing 2007-06-26 9:48 ` performance testing Valerie Clement @ 2007-06-26 10:36 ` Girish Shilamkar 2007-06-26 11:03 ` Valerie Clement 0 siblings, 1 reply; 3+ messages in thread From: Girish Shilamkar @ 2007-06-26 10:36 UTC (permalink / raw) To: Valerie Clement; +Cc: Alex Tomas, Andreas Dilger, ext4 development On Tue, 2007-06-26 at 11:48 +0200, Valerie Clement wrote: > Shouldn't it be : > > struct commit_header *tmp = (struct commit_header*)(bh->b_data + i); > Ohhh, yes you are right. This is the correct thing to do. This patch which is been used has some endian-ness bugs. I had sent an updated patch for 2.6.22-rc5 on 19 June. I think we should be using the updated patch else it may break on big-endian machines. Even the updated patch has this bug i.e "struct commit_header *tmp =...." Thanks, Girish. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: performance testing 2007-06-26 10:36 ` Girish Shilamkar @ 2007-06-26 11:03 ` Valerie Clement 0 siblings, 0 replies; 3+ messages in thread From: Valerie Clement @ 2007-06-26 11:03 UTC (permalink / raw) To: Girish Shilamkar; +Cc: Alex Tomas, Andreas Dilger, ext4 development Girish Shilamkar wrote: > On Tue, 2007-06-26 at 11:48 +0200, Valerie Clement wrote: >> Shouldn't it be : >> >> struct commit_header *tmp = (struct commit_header*)(bh->b_data + i); >> > Ohhh, yes you are right. This is the correct thing to do. > This patch which is been used has some endian-ness bugs. I had sent an > updated patch for 2.6.22-rc5 on > 19 June. I think we should be using the updated patch else it may break > on big-endian machines. > Even the updated patch has this bug i.e "struct commit_header *tmp > =...." > > Thanks, > Girish. > Hi Girish, I made the change on my system and tested it. Good news, everything seems to work well now. Could you please make and post the patch? Thanks, Valérie ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-26 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <467BE4C0.2020203@bull.net>
[not found] ` <1182541578.9939.3.camel@localhost.localdomain>
[not found] ` <467C99F5.6060603@clusterfs.com>
[not found] ` <1182755567.4067.1.camel@localhost.localdomain>
[not found] ` <467FE8A5.4030508@bull.net>
[not found] ` <467FEAF7.7060902@clusterfs.com>
[not found] ` <4680CE9B.1030602@bull.net>
2007-06-26 9:48 ` performance testing Valerie Clement
2007-06-26 10:36 ` Girish Shilamkar
2007-06-26 11:03 ` Valerie Clement
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).