linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: cmm@us.ibm.com
Cc: linux-ext4@vger.kernel.org
Subject: Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update
Date: Tue, 03 Jul 2007 12:25:14 +0530	[thread overview]
Message-ID: <4689F2D2.7020809@linux.vnet.ibm.com> (raw)
In-Reply-To: <1183275465.4010.130.camel@localhost.localdomain>



Mingming Cao wrote:
> This patch is on top of i_version_update_vfs.
> The i_version field of the inode is set on inode creation and incremented when
> the inode is being modified.
> ta));
>  	ei->i_dir_start_lookup = 0;
> Index: linux-2.6.22-rc4/fs/ext4/inode.c
> ===================================================================
> --- linux-2.6.22-rc4.orig/fs/ext4/inode.c	2007-06-13 17:21:29.000000000 -0700
> +++ linux-2.6.22-rc4/fs/ext4/inode.c	2007-06-13 17:24:45.000000000 -0700
> @@ -3082,6 +3082,7 @@ int ext4_mark_iloc_dirty(handle_t *handl
>  {
>  	int err = 0;
> 
> +	inode->i_version++;
>  	/* the do_update_inode consumes one bh->b_count */
>  	get_bh(iloc->bh);
> 

If we bump i_version  in ext4_mark_iloc_dity then we should be removing the i_version update
at other places. A simple grep of ext4 dir shows i_version being updated followed by 
ext4_mark_inode_dirty.


-aneesh

  parent reply	other threads:[~2007-07-03  6:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-01  7:37 [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update Mingming Cao
2007-07-03  6:49 ` Aneesh Kumar K.V
2007-07-03 21:41   ` Andreas Dilger
2007-07-03  6:55 ` Aneesh Kumar K.V [this message]
2007-07-04  5:26   ` Aneesh Kumar K.V
2007-07-04  3:31     ` Mingming Cao
2007-07-04  5:26   ` Aneesh Kumar K.V
2007-07-10 23:31 ` Andrew Morton
2007-07-11  8:47 ` Christoph Hellwig
2007-07-11 11:52   ` Andreas Dilger
2007-07-11 12:02     ` Christoph Hellwig
2007-07-11 11:54   ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4689F2D2.7020809@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).