Re: [PATCH 3/4] e2fsprogs: Make mke2fs use undo I/O manager.

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Andreas Dilger wrote:
> On Aug 01, 2007  07:34 +0530, Aneesh Kumar K.V wrote:
>> When running mke2fs, if a file system is detected
>> on the device, we use Undo I/O manager as the io manager.
>> This helps in reverting the changes made to the filesystem
>> in case we wrongly selected the device.
>>
>> The environment variable MKE2FS_SCRATCH_DIR
>> is used to indicate the  directory within which the tdb
>> file need to be created. The file will be named mke2fs-XXXXXX
> 
> It might be more useful to have "mke2fs-{dev}-{timestamp}" as
> the filename, so that it is clear where the image came from.
>

I added it as a FIXME!! in the code. So i was intending to do it.

+	/* FIXME!! Should we generate Unique file name ?? */
+	sprintf(tdb_file, "%s/mke2fs-XXXXXX", tdb_dir);



I will add it in my next patch set.

-aneesh