Re: [PATCH] removing e2fsprogs compiling warnings

[Coly Li <coyli@suse.de>]

clear, this is a perfect explaining for Signed-off-by :-)

Thanks a lot.

Coly

Theodore Tso wrote:
> On Sat, Aug 04, 2007 at 02:07:30PM +0800, Coly Li wrote:
>> Do you mean  "Signed-off-by Coly Li <coyli@suse.de>" ?
>> I just though this is used for others to sign my patch :-) 
> 
> No, it's really bad to add a Signed-off-by for anyone other than
> yourself, since it has legal significance.  It's something that you
> have to do for yourself.  :-)
> 
> Quoting from SUBMITTING-PATCHES:
> 
> The sign-off is a simple line at the end of the explanation for the
> patch, which certifies that you wrote it or otherwise have the right to
> pass it on as a open-source patch.  The rules are pretty simple: if you
> can certify the below:
> 
>         Developer's Certificate of Origin 1.1
> 
>         By making a contribution to this project, I certify that:
> 
>         (a) The contribution was created in whole or in part by me and I
>             have the right to submit it under the open source license
>             indicated in the file; or
> 
>         (b) The contribution is based upon previous work that, to the best
>             of my knowledge, is covered under an appropriate open source
>             license and I have the right under that license to submit that
>             work with modifications, whether created in whole or in part
>             by me, under the same open source license (unless I am
>             permitted to submit under a different license), as indicated
>             in the file; or
> 
>         (c) The contribution was provided directly to me by some other
>             person who certified (a), (b) or (c) and I have not modified
>             it.
> 
> 	(d) I understand and agree that this project and the contribution
> 	    are public and that a record of the contribution (including all
> 	    personal information I submit with it, including my sign-off) is
> 	    maintained indefinitely and may be redistributed consistent with
> 	    this project or the open source license(s) involved.
> 
> then you just add a line saying
> 
> 	Signed-off-by: Random J Developer <random@developer.example.org>
> 
> In this case of your gcc -Wall cleanups, the changes involved were
> small and probably fell below the threshold of something that could be
> protected by copyright --- and I ended up choosing a different way of
> cleaning up for one or two of the cleanups anyway.  But for anything
> non-trivial, these days I am requested a Developers Certification of
> Origin.
> 
> Regards,
> 
> 						- Ted
>