Re: [PATCH] e2fsprogs: remove fragment support (V3)

[Coly Li <coyli@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

Theodore,

Another question of mine is for the .po files: Once I modify a string from _(""), should I mofify
all the corresponded strings from all .po files ?

Theodore Tso wrote:
> On Sat, Aug 11, 2007 at 01:13:39AM +0800, Coly Li wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
> 
> If you're going to use PGP signatures, please use the MIME-PGP that
> doesn't cause annoying quoting to take place, i.e.:
> 
>> - -   switch (os) {
>> - -       case EXT2_OS_HURD:
>> - -           frag = inode->osd2.hurd2.h_i_frag;
> 
Oops, I thought that issues from my email client. OK, next time when I send patch I will use MIME-PGP.


> Also, please take a look at my recent patch series to remove support
> for PPC big-endian byte-swapped filesystems.  Separate patches which
> makes it obvious what is being removed and makes it easy to review are
> much appreciated.
> 

Sure, I agree with you.


> In addition, for now, I'd like to keep the code which checks the
> remaining fragment fields in the inode and superblock since they act
> as a safety check to make sure the filesystem is sane and we don't
> have garbage there.  The checksum fields will obviate this need, but
> keeping the checks there for ext2/ext3 filesystems seem like a good
> idea.

My idea is:
1) Modify names of related fields of superblock and inode. to avoid others using these field in future.
2) Keep checking code for the modified fields. to make source code robust.

> 
> Dropping the union is probably fine, since at this point it looks
> pretty clear that both the Hurd and Masix is dead.  But let's do the
> cleanups a little at a time, and I'd probably start with just removing
> the cruft from the mke2fs options and man pages.
> 

Sure, I agree with you :-)

> Regards,
> 
>     	       	   	  	      - Ted

-- 
Coly Li
SuSE PRC Labs


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]