From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] placate checkpatch.pl to some degree for mballoc.c
Date: Fri, 31 Aug 2007 20:12:59 -0500 [thread overview]
Message-ID: <46D8BC9B.8060005@redhat.com> (raw)
In-Reply-To: <20070831225854.GS5377@schatzie.adilger.int>
Andreas Dilger wrote:
> On Aug 31, 2007 16:28 -0500, Eric Sandeen wrote:
>> Here's a patch for mballoc.c, to make checkpatch happier with it.
>>
>> I was about as pedantic as I could be, except for a few things it
>> complained about which I just could not agree with. :)
>
> I'm happy with the changes, since I've adopted the kernel CodingStyle
> as my own, but not everyone at CFS has.
>
...
>>
>> -Eric
>>
>> Make checkpatch happier with mballoc.c
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> You can add my "Signed-off-by: Andreas Dilger <adilger@clusterfs.com>"
>
>> @@ -829,7 +845,8 @@ ext4_mb_mark_free_simple(struct super_bl
>> - mb_clear_bit(first >> min, buddy + sbi->s_mb_offsets[min]);
>> + mb_clear_bit(first >> min,
>> + buddy + sbi->s_mb_offsets[min]);
>
> Hmm, shouldn't "buddy" be aligned on the '(' from the previous line?
...
Yup, I did this a little bit fast & furious; I'll fix those up.
Thanks,
-Eric
next prev parent reply other threads:[~2007-09-01 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 21:28 [PATCH] placate checkpatch.pl to some degree for mballoc.c Eric Sandeen
2007-08-31 21:57 ` Mingming Cao
2007-08-31 22:58 ` Andreas Dilger
2007-09-01 1:12 ` Eric Sandeen [this message]
2007-09-01 2:38 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D8BC9B.8060005@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).