From: Valerie Clement <valerie.clement@bull.net>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: Bad performance results with the latest git patches
Date: Mon, 10 Sep 2007 13:39:40 +0200 [thread overview]
Message-ID: <46E52CFC.7080900@bull.net> (raw)
In-Reply-To: <20070907213716.GH5377@schatzie.adilger.int>
Andreas Dilger wrote:
> The problem was in the recently-added "extent sanity checks", and has
> also been fixed:
>
> Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
> Signed-off-by: Alex Tomas <alex@clusterfs.com>
> Signed-off-by: Johann Lombardi <johann@clusterfs.com>
>
> diff -u linux-2.6.18.8/fs/ext3/extents.c linux-2.6.18.8/fs/ext3/extents.c
> --- linux-2.6.18.8/fs/ext3/extents.c 2007-06-20 18:54:00.000000000 +0200
> +++ linux-2.6.18.8/fs/ext3/extents.c 2007-06-20 18:54:00.000000000 +0200
> @@ -1069,7 +1069,7 @@ ext3_ext_search_right(struct inode *inode,
> if (bh == NULL)
> return -EIO;
> eh = ext_block_hdr(bh);
> - if (ext3_ext_check_header(inode, eh, depth)) {
> + if (ext3_ext_check_header(inode, eh, path->p_depth - depth)) {
> brelse(bh);
> return -EIO;
> }
>
Thanks Andreas, I confirm this patch fixes the problem.
Valérie
prev parent reply other threads:[~2007-09-10 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 12:24 Bad performance results with the latest git patches Valerie Clement
2007-09-07 21:37 ` Andreas Dilger
2007-09-10 10:14 ` Aneesh Kumar K.V
2007-09-10 11:39 ` Valerie Clement [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E52CFC.7080900@bull.net \
--to=valerie.clement@bull.net \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).