From: Eric Sandeen <sandeen@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>,
hooanon05@yahoo.co.jp, sct@redhat.com, adilger@clusterfs.com,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: Fw: ext3 dir_index causes an error
Date: Fri, 14 Sep 2007 12:14:12 -0500 [thread overview]
Message-ID: <46EAC164.6000900@redhat.com> (raw)
In-Reply-To: <46E840A0.4030504@redhat.com>
Eric Sandeen wrote:
> Andrew Morton wrote:
>> Ted is dir_index maintainer ;)
...
>> [1.] One line summary of the problem:
>> ext3 dir_index causes an error
>
> I'm looking at this now, FWIW... pretty easy to reproduce on ppc64,
> though I've not yet hit it on x86.
The issue here is that do_split() splits a leaf node at the entry with
the median hash value, after sorting by hash... but it pays no attention
to the resulting size of the records in the old & new blocks.
If you're unlucky, and your split is lopsided size-wise, you may not
have space in the block chosen for the new entry. This is not checked,
however, and things go bad quickly.
Talked with Andreas a little about this, looking into the best way to
fix it up.
-Eric
next prev parent reply other threads:[~2007-09-14 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 4:15 Fw: ext3 dir_index causes an error Andrew Morton
2007-09-12 19:40 ` Eric Sandeen
2007-09-14 17:14 ` Eric Sandeen [this message]
2007-09-15 0:00 ` Goswin von Brederlow
2007-09-15 3:24 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EAC164.6000900@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-ext4@vger.kernel.org \
--cc=sct@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).