Re: [PATCH] Ext4: Uninitialized Block Groups

[Valerie Clement <valerie.clement@bull.net>]

Aneesh Kumar K.V wrote:
> the variable free is confusingly named here. It is not the free inode 
> count.
> rather it indicate the last used relative inode number in the group. How 
> about
> the below ?
> 
> -aneesh

I agree, it's better.
   Valérie

> 
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 4250c02..cfe2e09 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -633,17 +633,21 @@ got:
>     /* If we didn't allocate from within the initialized part of the inode
>      * table then we need to initialize up to this inode. */
>     if (EXT4_HAS_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_GDT_CSUM)) {
> -        if (gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_UNINIT)) {
> +        if (gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_UNINIT))
>             gdp->bg_flags &= cpu_to_le16(~EXT4_BG_INODE_UNINIT);
> -            free = EXT4_INODES_PER_GROUP(sb);
> -        } else {
> -            free = EXT4_INODES_PER_GROUP(sb) -
> -                le16_to_cpu(gdp->bg_itable_unused);
> -        }
> 
> -        if (ino > free)
> +        /*
> +         * Check the relative inode number against the last used
> +         * relative inode number in this group. if it is greater
> +         * we need to  update the bg_itable_unused count
> +         *
> +         */
> +        if (ino > (EXT4_INODES_PER_GROUP(sb) -
> +                    le16_to_cpu(gdp->bg_itable_unused))) {
> +
>             gdp->bg_itable_unused =
>                 cpu_to_le16(EXT4_INODES_PER_GROUP(sb) - ino);
> +        }
>     }
> 
>     gdp->bg_free_inodes_count =
>