From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH e2fsprogs] - ignore bind mounts in fsck
Date: Wed, 19 Sep 2007 15:20:14 -0500 [thread overview]
Message-ID: <46F1847E.6080400@redhat.com> (raw)
An entry like this in /etc/fstab:
/foo /bar ext3 bind,defaults 1 3
will stop boot, as fsck.ext3 tries to check it and fails:
e2fsck 1.40.2 (12-Jul-2007)
fsck.ext3: Is a directory while trying to open /foo
The superblock could not be read or does not describe a correct ext2
filesystem. ...
Granted, asking for fsck of a bind mount in the fstab is a bit odd,
but it doesn't seem like it should stop the boot process if you make
this mistake.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Index: e2fsprogs-1.40.2/misc/fsck.c
===================================================================
--- e2fsprogs-1.40.2.orig/misc/fsck.c
+++ e2fsprogs-1.40.2/misc/fsck.c
@@ -867,6 +867,12 @@ static int ignore(struct fs_info *fs)
if (fs->passno == 0)
return 1;
+ /*
+ * If this is a bind mount, ignore it.
+ */
+ if (opt_in_list("bind", fs->opts))
+ return 1;
+
interpret_type(fs);
/*
next reply other threads:[~2007-09-19 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 20:20 Eric Sandeen [this message]
2007-09-19 20:42 ` [PATCH e2fsprogs] - ignore bind mounts in fsck Theodore Tso
2007-09-20 14:31 ` Eric Sandeen
2007-09-20 14:42 ` Theodore Tso
2007-09-20 15:12 ` Eric Sandeen
2007-09-20 18:59 ` Theodore Tso
2007-09-20 19:08 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F1847E.6080400@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).