public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Patch format in ext4 patch queue.
Date: Fri, 21 Sep 2007 16:03:26 +0530	[thread overview]
Message-ID: <46F39DF6.30402@linux.vnet.ibm.com> (raw)

Hi all,

I was looking at the patch queue and see patches with different formats. 
If we can standardize on what rest of the linux kernel follows it would
be nice.

First line should be
<subsystem_name>: A single line description of the patch.
This appear in the subject line of the mail that results from different
commit list. 

eg: ext4: Uninitialized block group support


From: <Author of the patch>
This should be a valid email id. For example stgit checks for the 
author to be a valid email id. 


<Description of the fix>

Signed-off-by:
Reviewed-by:

What is missing in the patch queue is the First line for most of the patch.

Below is the steps i follow to manage patch queue.

One linux kernel repository:


[master@linux-review-ext4]$ git checkout -b review v2.6.23-rc6
Switched to a new branch "review"
[review@linux-review-ext4]$ stg init 
[review@linux-review-ext4]$ stg import --series /home/opensource/patches/ext4-patch-queue/series 

Now we should verify patches and make sure they look the way we wanted them in Linus tree by git log 

After:
stg pop -> similar to quilt pop
stg push -> similar to quilt push

To edit the commit message
stg edit 

To add sign-off or ack

stg edit --sign 
stg edit --ack

To change the author name
stg edit --author


Now once we are sure all are fine

stg export -d /home/new-patch-queue-set/

This should get a patch set with quilt series


To find stgit:

http://procode.org/stgit/


-aneesh 

             reply	other threads:[~2007-09-21 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21 10:33 Aneesh Kumar K.V [this message]
2007-09-21 11:24 ` Patch format in ext4 patch queue Aneesh Kumar K.V
2007-09-21 11:46 ` Theodore Tso
2007-09-24 21:34 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F39DF6.30402@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox