linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Jan Kara <jack@suse.cz>
Cc: richard kennedy <richard@rsk.demon.co.uk>,
	sct@redhat.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: jbd : config_jbd_debug cannot create /proc entry
Date: Tue, 25 Sep 2007 16:34:06 +0530	[thread overview]
Message-ID: <46F8EB26.2090104@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070925105112.GB8126@atrey.karlin.mff.cuni.cz>



Jan Kara wrote:
>> 
> -#define create_jbd_proc_entry() do {} while (0)
> -#define remove_jbd_proc_entry() do {} while (0)
> +static ctl_table fs_table[] = {
> +	{
> +                .ctl_name       = -1,	/* Don't want it */



shouldn't this be CTL_UNNUMBERED ?


> +                .procname       = "jbd-debug",
> +                .data           = &journal_enable_debug,
> +                .maxlen         = sizeof(int),
> +                .mode           = 0644,
> +                .proc_handler   = &proc_dointvec,
> +        },
> +        { .ctl_name = 0 },
> +};
>

-aneesh

  reply	other threads:[~2007-09-25 11:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25  9:40 jbd : config_jbd_debug cannot create /proc entry richard kennedy
2007-09-25 10:51 ` Jan Kara
2007-09-25 11:04   ` Aneesh Kumar K.V [this message]
2007-09-25 11:50     ` Jan Kara
2007-09-25 12:49       ` Jose R. Santos
2007-09-25 13:41         ` Jose R. Santos
2007-09-25 14:36           ` Jan Kara
2007-09-26 21:35             ` Andrew Morton
2007-09-27  5:23               ` Jose R. Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F8EB26.2090104@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@rsk.demon.co.uk \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).