Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Dave Kleikamp wrote:
> On Tue, 2007-09-25 at 14:33 +0530, Aneesh Kumar K.V wrote:
>> ext4 file system layout contain different split members
>> like bg_block_bitmap  and bg_block_bitmap_hi. Introduce
>> data type le32_t and le16_t to be used as the type of
>> these split members. This prevents these members frome
>> being accessed directly. Accesing them directly gives
>> a compiler warning. This helps in catching some BUGS
>> due to direct partial access of these split fields.
> 
> Ugh.  I don't like this typedef at all. It just makes the data type more
> confusing.


Confusing enough to make people look at them more carefully.



> 
> Why not just change the name of bg_block_bitmap to something like
> bg_block_bitmap_lo or _bg_block_bitmap?  It should be clear from the
> name that it shouldn't be used without careful consideration.
> 

even if we rename the variables, I guess we would like to have helper functions
for accessing these values. That would mean the code is finally going to look more
or less the same except the typedef. But the typedef actually save us from serious
misuse of these variables.


-aneesh