From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alex Tomas <alex@clusterfs.com>,
Andreas Dilger <adilger@clusterfs.com>,
Mingming Cao <cmm@us.ibm.com>,
Avantika Mathur <mathur@linux.vnet.ibm.com>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: new mballoc patches.
Date: Thu, 27 Sep 2007 12:03:22 +0530 [thread overview]
Message-ID: <46FB4EB2.3090802@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070926225821.8cc6a2e0.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 11 Sep 2007 13:59:26 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
>
>> I have updated the mballoc patches.
>
> Has anyone reviewed this stuff? I don't see much evidence of it here?
>
> Just a quick scan shows up heavy over-inlining, many
> macros-which-should-be-functions and numerous needlessly global symbols.
> Whether there are more substantial problems in there I have not the time to
> tell.
I idea of getting it added to the patch queue was to get more testing and also review.
I am right now looking at the code trying to add more documentation. Things which are not
clear at the moment is marked with FIXME!!.
-aneesh
prev parent reply other threads:[~2007-09-27 6:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 8:29 new mballoc patches Aneesh Kumar K.V
2007-09-11 15:04 ` Aneesh Kumar K.V
[not found] ` <46E7DF34.8090209@bull.net>
2007-09-12 17:59 ` Aneesh Kumar K.V
2007-09-13 0:30 ` Mingming Cao
2007-09-11 23:18 ` Mingming Cao
2007-09-13 2:51 ` Aneesh Kumar K.V
2007-09-14 12:10 ` Aneesh Kumar K.V
2007-09-30 3:51 ` Alex Tomas
2007-09-27 5:58 ` Andrew Morton
2007-09-27 6:33 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FB4EB2.3090802@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=alex@clusterfs.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mathur@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).