* When to set EXT4_FEATURE_RO_COMPAT_LARGE_FILE ?
@ 2007-10-11 17:04 Aneesh Kumar K.V
0 siblings, 0 replies; only message in thread
From: Aneesh Kumar K.V @ 2007-10-11 17:04 UTC (permalink / raw)
To: linux-ext4, Theodore Tso, Andreas Dilger, Mingming Cao
Right now we do this in ext4_do_update_inode
if (ei->i_disksize > 0x7fffffffULL) {
.....
.....
EXT4_SET_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_LARGE_FILE);
That is if i_disksize is greater that 2**31 -1 we set the flag
But in ext4_inode the size of i_size is 32 bits
__le32 i_size; /* Size in bytes */
That means it should be able to store ffffffffULL.
Why did we decided to enable the EXT4_FEATURE_RO_COMPAT_LARGE_FILE when we cross 2**31 -1 ?
NOTE: With EXT4_FEATURE_RO_COMPAT_LARGE_FILE we store the higer order 32 bits of i_size in i_dir_acl.
-aneesh
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-10-11 17:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-11 17:04 When to set EXT4_FEATURE_RO_COMPAT_LARGE_FILE ? Aneesh Kumar K.V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).