* [PATCH][e2fsprogs] add -E option to mke2fs usage information
@ 2007-10-15 14:19 Coly Li
2007-10-15 21:00 ` Theodore Tso
0 siblings, 1 reply; 4+ messages in thread
From: Coly Li @ 2007-10-15 14:19 UTC (permalink / raw)
To: linux-ext4
-E option is missed from usage information of mke2fs. This patch adds -E option to usage
information, and names -E|-R as extended-option.
Now the usage information can be consistent with mke2fs.8.in.
Signed-off-by: Coly Li <coyli@suse.de>
---
misc/mke2fs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 4a6cace..128aa43 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -100,7 +100,7 @@ static void usage(void)
"\t[-N number-of-inodes] [-m reserved-blocks-percentage] "
"[-o creator-os]\n\t[-g blocks-per-group] [-L volume-label] "
"[-M last-mounted-directory]\n\t[-O feature[,...]] "
- "[-r fs-revision] [-R options] [-qvSV]\n\tdevice [blocks-count]\n"),
+ "[-r fs-revision] [-E|-R extended-option[,...]] [-qvSV]\n\tdevice [blocks-count]\n"),
program_name);
exit(1);
}
--
Coly Li
SuSE PRC Labs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][e2fsprogs] add -E option to mke2fs usage information
2007-10-15 14:19 [PATCH][e2fsprogs] add -E option to mke2fs usage information Coly Li
@ 2007-10-15 21:00 ` Theodore Tso
2007-10-16 3:21 ` Coly Li
2007-10-16 3:22 ` Coly Li
0 siblings, 2 replies; 4+ messages in thread
From: Theodore Tso @ 2007-10-15 21:00 UTC (permalink / raw)
To: Coly Li; +Cc: linux-ext4
On Mon, Oct 15, 2007 at 10:19:11PM +0800, Coly Li wrote:
> -E option is missed from usage information of mke2fs. This patch adds -E option to usage
> information, and names -E|-R as extended-option.
> Now the usage information can be consistent with mke2fs.8.in.
Please fill comments to 80 columns; thanks!!
I checked this into the maint branch, but I just changed the message
to use -E only. The use of -R is deprecated, but supported for
backwards compatibility; so there's no point putting it in the usage
message.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][e2fsprogs] add -E option to mke2fs usage information
2007-10-15 21:00 ` Theodore Tso
@ 2007-10-16 3:21 ` Coly Li
2007-10-16 3:22 ` Coly Li
1 sibling, 0 replies; 4+ messages in thread
From: Coly Li @ 2007-10-16 3:21 UTC (permalink / raw)
To: Theodore Tso; +Cc: linux-ext4
Theodore Tso wrote:
> On Mon, Oct 15, 2007 at 10:19:11PM +0800, Coly Li wrote:
>> -E option is missed from usage information of mke2fs. This patch adds -E option to usage
>> information, and names -E|-R as extended-option.
>> Now the usage information can be consistent with mke2fs.8.in.
>
> Please fill comments to 80 columns; thanks!!
I will note this in future patches :-)
>
> I checked this into the maint branch, but I just changed the message
> to use -E only. The use of -R is deprecated, but supported for
> backwards compatibility; so there's no point putting it in the usage
> message.
Thanks for the message :-)
>
> - Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][e2fsprogs] add -E option to mke2fs usage information
2007-10-15 21:00 ` Theodore Tso
2007-10-16 3:21 ` Coly Li
@ 2007-10-16 3:22 ` Coly Li
1 sibling, 0 replies; 4+ messages in thread
From: Coly Li @ 2007-10-16 3:22 UTC (permalink / raw)
To: Theodore Tso; +Cc: linux-ext4
Theodore Tso wrote:
> On Mon, Oct 15, 2007 at 10:19:11PM +0800, Coly Li wrote:
>> -E option is missed from usage information of mke2fs. This patch adds -E option to usage
>> information, and names -E|-R as extended-option.
>> Now the usage information can be consistent with mke2fs.8.in.
>
> Please fill comments to 80 columns; thanks!!
I will follow this in future patches :-)
>
> I checked this into the maint branch, but I just changed the message
> to use -E only. The use of -R is deprecated, but supported for
> backwards compatibility; so there's no point putting it in the usage
> message.
Thanks for the message :-)
>
> - Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-16 3:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 14:19 [PATCH][e2fsprogs] add -E option to mke2fs usage information Coly Li
2007-10-15 21:00 ` Theodore Tso
2007-10-16 3:21 ` Coly Li
2007-10-16 3:22 ` Coly Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).