* [PATCH] provide missing mode for open-create in check_mntent_file
@ 2007-08-16 22:37 Eric Sandeen
2007-08-17 17:29 ` Andreas Dilger
2007-10-19 20:15 ` Eric Sandeen
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2007-08-16 22:37 UTC (permalink / raw)
To: ext4 development
F8 is catching opens with O_CREAT flags and no mode now, and refusing
to build them...
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Index: e2fsprogs-git/lib/ext2fs/ismounted.c
===================================================================
--- e2fsprogs-git.orig/lib/ext2fs/ismounted.c
+++ e2fsprogs-git/lib/ext2fs/ismounted.c
@@ -147,7 +147,7 @@ static errcode_t check_mntent_file(const
is_root:
#define TEST_FILE "/.ismount-test-file"
*mount_flags |= EXT2_MF_ISROOT;
- fd = open(TEST_FILE, O_RDWR|O_CREAT);
+ fd = open(TEST_FILE, O_RDWR|O_CREAT, 0644);
if (fd < 0) {
if (errno == EROFS)
*mount_flags |= EXT2_MF_READONLY;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] provide missing mode for open-create in check_mntent_file
2007-08-16 22:37 [PATCH] provide missing mode for open-create in check_mntent_file Eric Sandeen
@ 2007-08-17 17:29 ` Andreas Dilger
2007-10-19 20:15 ` Eric Sandeen
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Dilger @ 2007-08-17 17:29 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development
On Aug 16, 2007 17:37 -0500, Eric Sandeen wrote:
> F8 is catching opens with O_CREAT flags and no mode now, and refusing
> to build them...
Yay, we had bugs-o-plenty in Lustre because of this being done in apps.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] provide missing mode for open-create in check_mntent_file
2007-08-16 22:37 [PATCH] provide missing mode for open-create in check_mntent_file Eric Sandeen
2007-08-17 17:29 ` Andreas Dilger
@ 2007-10-19 20:15 ` Eric Sandeen
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2007-10-19 20:15 UTC (permalink / raw)
To: ext4 development
Eric Sandeen wrote:
> F8 is catching opens with O_CREAT flags and no mode now, and refusing
> to build them...
Ping? I don't see this in git yet.
Thanks,
-Eric
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Index: e2fsprogs-git/lib/ext2fs/ismounted.c
> ===================================================================
> --- e2fsprogs-git.orig/lib/ext2fs/ismounted.c
> +++ e2fsprogs-git/lib/ext2fs/ismounted.c
> @@ -147,7 +147,7 @@ static errcode_t check_mntent_file(const
> is_root:
> #define TEST_FILE "/.ismount-test-file"
> *mount_flags |= EXT2_MF_ISROOT;
> - fd = open(TEST_FILE, O_RDWR|O_CREAT);
> + fd = open(TEST_FILE, O_RDWR|O_CREAT, 0644);
> if (fd < 0) {
> if (errno == EROFS)
> *mount_flags |= EXT2_MF_READONLY;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-19 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-16 22:37 [PATCH] provide missing mode for open-create in check_mntent_file Eric Sandeen
2007-08-17 17:29 ` Andreas Dilger
2007-10-19 20:15 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).