linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: should ext2fs_get_device_size() be returning EFBIG for >8T (or 16T?)
Date: Tue, 23 Oct 2007 13:43:22 -0500	[thread overview]
Message-ID: <471E40CA.2070500@redhat.com> (raw)

I have a bug saying hey, I can't grow my filesystem on a 16T device, and
it's because really we can only go to (2^32)-1 blocks, not (2^32)...

I was going to just silently round down by a block, because for example
LVM makes it *very* easy to make exactly 16T devices; dropping a block
at mkfs/growfs time seems reasonable to me.

So that led me to ext2fs_get_device_size, and I see it actually has the
maximum allowable filesystem size encoded in it, and you get EFBIG if
it's bigger.

I think this disallows you from being able to specify a smaller size on
the resize cmdline too; the device size check bails out before that.

I'm not sure what the plan is for size checks in the ext4 world, but it
seems to me that the device size check and the acceptable fs size checks
should be separate things.

Comments?

Thanks,
-Eric

             reply	other threads:[~2007-10-23 18:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 18:43 Eric Sandeen [this message]
2007-10-23 18:48 ` should ext2fs_get_device_size() be returning EFBIG for >8T (or 16T?) Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471E40CA.2070500@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).