* [PATCH] Fix oops with jbd-stats-through-procfs and external journal
@ 2007-10-25 16:39 Eric Sandeen
2007-10-25 19:24 ` Mingming Cao
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2007-10-25 16:39 UTC (permalink / raw)
To: ext4 development; +Cc: johann.lombardi, Mingming Cao
When using an external device for the journal,
jbd2_stats_proc_init() wants to use journal->j_dev in its call
to bdevname() but it's not assigned yet, resulting in an oops.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
--- linux.orig/fs/jbd2/journal.c 2007-10-25 11:36:25.772354262 -0500
+++ linux/fs/jbd2/journal.c 2007-10-25 11:36:35.058278242 -0500
@@ -1035,11 +1035,11 @@
journal = NULL;
goto out;
}
- jbd2_stats_proc_init(journal);
journal->j_dev = bdev;
journal->j_fs_dev = fs_dev;
journal->j_blk_offset = start;
journal->j_maxlen = len;
+ jbd2_stats_proc_init(journal);
bh = __getblk(journal->j_dev, start, journal->j_blocksize);
J_ASSERT(bh != NULL);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix oops with jbd-stats-through-procfs and external journal
2007-10-25 16:39 [PATCH] Fix oops with jbd-stats-through-procfs and external journal Eric Sandeen
@ 2007-10-25 19:24 ` Mingming Cao
0 siblings, 0 replies; 2+ messages in thread
From: Mingming Cao @ 2007-10-25 19:24 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development, johann.lombardi
Thanks, Added to ext4 patch queue at
http://repo.or.cz/w/ext4-patch-queue.git
On Thu, 2007-10-25 at 11:39 -0500, Eric Sandeen wrote:
> When using an external device for the journal,
> jbd2_stats_proc_init() wants to use journal->j_dev in its call
> to bdevname() but it's not assigned yet, resulting in an oops.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> --- linux.orig/fs/jbd2/journal.c 2007-10-25 11:36:25.772354262 -0500
> +++ linux/fs/jbd2/journal.c 2007-10-25 11:36:35.058278242 -0500
> @@ -1035,11 +1035,11 @@
> journal = NULL;
> goto out;
> }
> - jbd2_stats_proc_init(journal);
> journal->j_dev = bdev;
> journal->j_fs_dev = fs_dev;
> journal->j_blk_offset = start;
> journal->j_maxlen = len;
> + jbd2_stats_proc_init(journal);
>
> bh = __getblk(journal->j_dev, start, journal->j_blocksize);
> J_ASSERT(bh != NULL);
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-25 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-25 16:39 [PATCH] Fix oops with jbd-stats-through-procfs and external journal Eric Sandeen
2007-10-25 19:24 ` Mingming Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).