linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Tomas <bzzz.tomas@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Andreas Dilger <adilger@clusterfs.com>,
	Eric Sandeen <sandeen@redhat.com>,
	Valerie Clement <valerie.clement@bull.net>,
	Theodore Tso <tytso@mit.edu>, Mingming Cao <cmm@us.ibm.com>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [RFC/PATCH] ext4: Clear the reservation window correctly with delayed allocation.
Date: Tue, 30 Oct 2007 14:24:42 +0300	[thread overview]
Message-ID: <4727147A.1060109@gmail.com> (raw)
In-Reply-To: <47270F0B.8010708@linux.vnet.ibm.com>

what if writepages went through 100 pages only and another 100 are left because
negative wbc->nr_to_write?

thanks, Alex

Aneesh Kumar K.V wrote:
> @@ -1410,7 +1410,14 @@ out:
> static int ext4_da_writepages(struct address_space *mapping,
>                   struct writeback_control *wbc)
> {
> -    return mpage_da_writepages(mapping, wbc, ext4_da_get_block_write);
> +    int retval;
> +    retval = mpage_da_writepages(mapping, wbc, ext4_da_get_block_write);
> +    if (!retval) {
> +        /* if writepages is successfull discard the reservation */
> +        ext4_discard_reservation(mapping->host);
> +    }
> +
> +    return retval;
> }
> 
> static void ext4_da_invalidatepage(struct page *page, unsigned long offset)
> 
> 
> -aneesh
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2007-10-30 11:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 10:00 delalloc and reservation Aneesh Kumar K.V
2007-10-29 11:07 ` Aneesh Kumar K.V
2007-10-30 11:01   ` [RFC/PATCH] ext4: Clear the reservation window correctly with delayed allocation Aneesh Kumar K.V
2007-10-30 11:24     ` Alex Tomas [this message]
2007-10-29 15:14 ` delalloc and reservation Alex Tomas
2007-10-29 14:33   ` Aneesh Kumar K.V
2007-10-29 15:44     ` Alex Tomas
2007-10-29 15:19       ` Aneesh Kumar K.V
2007-10-29 16:26         ` Alex Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4727147A.1060109@gmail.com \
    --to=bzzz.tomas@gmail.com \
    --cc=adilger@clusterfs.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    --cc=valerie.clement@bull.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).