Re: [PATCH] e2fsprogs: add minimal resize size option

[Eric Sandeen <sandeen@redhat.com>]

Theodore Tso wrote:
> On Wed, Jan 02, 2008 at 03:16:59PM -0500, Josef Bacik wrote:
>> Hello,
>>
>> People wishing to make live usb disks and such are looking for a way
>> to get the minimum resize size for an ext fs in blocks so that they
>> can just resize their image to that size and do with it what they
>> will.  This patch adds that functionality, just pass -m option and
>> it calculates the minimum number of blocks the fs can be resized to.
> 
> Three comments.  Instead of using a new option, why not simply let
> resize2fs check to see if the optional parameter is something like
> "min" or "0"?

How about spitting out minimum size message whenever a too-small size is
specified; 0 would then of course always take no action, but simply
print the minimum.  For a size that's actually specified, but too small,
it'd still be useful I think, to say "XXXXX blocks is too small, minimum
size is YYYYY" ?

0 could be special-cased to not print the "0 blocks is too small" part
(or whatever...)

-Eric