Re: Integrating patches in SLES10 e2fsprogs

[Eric Sandeen <sandeen@redhat.com>]

Theodore Tso wrote:

> Patch10:        close.patch
> 
> I don't understand what this patch is trying to do.

* Tue Nov 15 2005 jblunck@suse.de
- added close.patch provided by Ted Tso (IBM) to fix bug #132708

*grin* Maybe obsolete by now?  haven't looked closely.

> Patch12:        e2fsprogs-mkinstalldirs.patch
> 
> Why?
> 

Probably same as why we have something similar; for one reason or other
need to rerun autoconf, and e2fsprogs isn't compatible with latest
autoconf.  (This is a patch I inherited, and haven't yet investigated
all the details)

> Patch22:        e2fsprogs-1.40.4-uuidd_pid_path.patch
> 
> The problem with this patch is that /var/run is cleared via rm -rf, so
> it is highly problamtic to put the scratch directory for uuidd in
> /var/run.

Hm, I had similar issues with uuidd too - common theme here?

> 
> Patch32:        libcom_err-no-e2fsck.static.patch
> 
> This patch does two completely unrelated things.  One is to disable
> the libcom_err regression test suite (probably because some of the
> other changes made) and the other is to disable building the
> e2fsck.static file.  Why these two are bundled into a single patch I'm
> not sure.

And I have a patch to do the latter as well.  Interesting how we've
arrived at similar needed changes, independently.  :)

and Patch99:        e2fsprogs-no_cmd_hiding.patch

honestly I like that; I should whip up a nice patch to emulate kbuild,
with V=1 or something, unless there is some other easy way to show full
build commands already?

-Eric