From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE boxes
Date: Fri, 14 Mar 2008 12:42:36 -0500 [thread overview]
Message-ID: <47DAB90C.8050605@redhat.com> (raw)
In-Reply-To: <20080314171435.GA13733@mit.edu>
Theodore Tso wrote:
> On Fri, Feb 29, 2008 at 04:10:21PM -0600, Eric Sandeen wrote:
>> +
>> + if (hostorder)
>> + attr_magic = *eaf;
>> *eat = ext2fs_swab32(*eaf);
>> + if (!hostorder)
>> + attr_magic = *eat;
>> +
>> + if (attr_magic != EXT2_EXT_ATTR_MAGIC)
>> + return; /* it seems no magic here */
>
> The problem with this is that if the magic isn't there, we still end
> up writing 4 bytes into the destination. So I think this is a better
> patch....
>
Seems good to me.
Thanks,
-Eric
prev parent reply other threads:[~2008-03-14 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 22:10 [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE boxes Eric Sandeen
2008-03-14 13:09 ` Matthias Koenig
2008-03-14 13:32 ` Theodore Tso
2008-03-14 14:13 ` Eric Sandeen
2008-03-14 14:40 ` Theodore Tso
2008-03-14 17:14 ` Theodore Tso
2008-03-14 17:42 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DAB90C.8050605@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).