linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Tiger Yang <tiger.yang@oracle.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle()
Date: Tue, 13 May 2008 07:48:49 -0500	[thread overview]
Message-ID: <48298E31.7050205@redhat.com> (raw)
In-Reply-To: <482947C3.9040601@oracle.com>

Tiger Yang wrote:
> Hi, Eric,
> 
> I don't have tesecase about this bug. I did the test manually. I use 
> khexedit to confirm the attributes whether in inody or block.
> The problem about this bug is we want to replace an existing attribute 
> in ibody with big size value which larger than free space in ibody.
> Because we didn't do block_find(), so the struct bs have not been 
> initialized. Then when we try to set attribute in block by block_set(), 
> we find bs->base is empty, we need alloc a new block for attributes. The 
> old block pointed by i_file_acl will lost with attributes in it.

Thanks, I'll go for a reproducer.  We use xattrs a lot for selinux in
Red Hat and Fedora, so a little surprised I haven't seen this bug... or
maybe it explains some bugs I haven't yet figured out ... :)

Thanks,
-Eric

  reply	other threads:[~2008-05-13 12:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12  3:24 [PATCH] ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle() Tiger Yang
2008-05-13  0:02 ` Andrew Morton
2008-05-13  2:31   ` Tiger Yang
2008-05-13 20:00     ` Andreas Dilger
2008-05-14 10:56     ` Andreas Gruenbacher
2008-05-14 16:00       ` [stable] " Greg KH
2008-05-14 17:28         ` Andrew Morton
2008-05-14 22:30           ` Theodore Tso
2008-05-14 22:54             ` Andrew Morton
2008-05-13  0:18 ` Eric Sandeen
2008-05-13  7:48   ` Tiger Yang
2008-05-13 12:48     ` Eric Sandeen [this message]
2008-05-13  8:48   ` Kalpak Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48298E31.7050205@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiger.yang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).