From: Eric Sandeen <sandeen@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Theodore Tso <tytso@mit.edu>,
cmm@us.ibm.com, linux-ext4@vger.kernel.org, alex@clusterfs.com,
adilger@sun.com
Subject: Re: [PATCH] ext4: Fix use of uninitialized data
Date: Mon, 02 Jun 2008 09:23:32 -0500 [thread overview]
Message-ID: <48440264.7090000@redhat.com> (raw)
In-Reply-To: <20080602141719.GA20714@skywalker>
Aneesh Kumar K.V wrote:
> On Mon, Jun 02, 2008 at 08:42:24AM -0500, Eric Sandeen wrote:
>> so it's fine... but why are we carrying around a field in the sbi to
>> hold a constant that cannot be changed runtime?
>
> We can tune that via MB_PROC_FOPS(group_prealloc);
MB_PROC_VALUE_WRITE()....
ah, cleverly hidden from cscope with a macro. :)
Ok, so technically then this could be big enough to overflow fe_len:
value = simple_strtol(str, NULL, 0); \
if (value <= 0) \
return -ERANGE; \
sbi->s_mb_##name = value; \
but I guess it's probably not the first thing we need to worry about.
-Eric
next prev parent reply other threads:[~2008-06-02 14:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 18:47 [PATCH] ext4: printk stack trace on ext4_error, ext4_abort and ext4_warning Aneesh Kumar K.V
2008-05-14 18:47 ` [PATCH] ext4: Fix use of uninitialized data Aneesh Kumar K.V
2008-05-14 18:47 ` [PATCH] ext4: Fix FLEX_BG and uninit group usage Aneesh Kumar K.V
2008-05-14 19:08 ` Jose R. Santos
2008-05-15 4:06 ` Aneesh Kumar K.V
2008-05-15 16:32 ` Jose R. Santos
2008-06-02 0:08 ` [PATCH] ext4: Fix use of uninitialized data Theodore Tso
2008-06-02 8:59 ` Aneesh Kumar K.V
2008-06-02 10:02 ` Shen Feng
2008-06-02 10:32 ` Aneesh Kumar K.V
2008-06-03 0:57 ` Shen Feng
2008-06-03 20:02 ` Andreas Dilger
2008-06-02 13:42 ` Eric Sandeen
2008-06-02 14:17 ` Aneesh Kumar K.V
2008-06-02 14:23 ` Eric Sandeen [this message]
2008-05-14 19:07 ` [PATCH] ext4: printk stack trace on ext4_error, ext4_abort and ext4_warning Eric Sandeen
2008-05-14 19:44 ` Theodore Tso
2008-05-15 4:25 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48440264.7090000@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=alex@clusterfs.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).