From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH e2fsprogs] blkid: fix swap tests (again)
Date: Wed, 18 Jun 2008 14:58:55 -0500 [thread overview]
Message-ID: <485968FF.3020905@redhat.com> (raw)
Some architectures (ppc ...) need a bigger swapfile than is shipped,
in the test image so the current re-make of swap was failing.
We could either ship a bigger image or just dd a bigger file...
There is one more minor problem with the tests; older mkswap does not
support the -U uuid specification. I'm not sure offhand what to do
about that problem, or if it really needs fixing.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Index: devel/e2fsprogs-1.41-WIP/lib/blkid/test_probe.in
===================================================================
--- e2fsprogs-1.41-WIP.orig/lib/blkid/test_probe.in 2008-06-16 12:08:45.000000000 -0500
+++ e2fsprogs-1.41-WIP/lib/blkid/test_probe.in 2008-06-16 14:56:33.437233901 -0500
@@ -20,10 +20,13 @@ do
continue
fi
bunzip2 < $SRCDIR/tests/$i.img.bz2 > tests/tmp/test.img.$$
- # swap is native-endian, so regenerate before testing
if [ "$i" = "swap0" ]; then
+ # swap is native-endian, so regenerate before testing
+ dd if=/dev/zero of=tests/tmp/test.img.$$ bs=16k count=64
mkswap -v0 tests/tmp/test.img.$$ > /dev/null
elif [ "$i" = "swap1" ]; then
+ # swap is native-endian, so regenerate before testing
+ dd if=/dev/zero of=tests/tmp/test.img.$$ bs=16k count=64
mkswap -v1 -L SWAP-TEST -U 8ff8e77f-8553-485e-8656-58be67a81666 tests/tmp/test.img.$$ >/dev/null
fi
./tst_probe tests/tmp/test.img.$$ > tests/$i.out
next reply other threads:[~2008-06-18 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 19:58 Eric Sandeen [this message]
2008-06-21 18:23 ` [PATCH e2fsprogs] blkid: fix swap tests (again) Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485968FF.3020905@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox