Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Anand Suveer Jain <asj@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>, Anand Jain <asj@kernel.org>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, zlang@redhat.com,
	hch@infradead.org
Subject: Re: [PATCH v7 04/11] fstests: add _require_unique_f_fsid() helper
Date: Wed, 22 Jul 2026 06:37:12 +0800	[thread overview]
Message-ID: <48637a77-b2ec-47e8-ac77-d397660c482b@kernel.org> (raw)
In-Reply-To: <20260701171122.GF6517@frogsfrogsfrogs>


> _require_unique_fsid(
> {
> 	case "$FSTYP" in
> 	ext*)
> 		# Ext4 derives f_fsid from the superblock UUID, meaning
> 		# clones share the same f_fsid until their UUIDs
> 		# diverge.
> 		_notrun "Target filesystem ($FSTYP) does not guarantee unique f_fsid on clones."
> 		;;
> 	*)
> 		# Conversely, XFS, Btrfs, and F2FS ensure f_fsid remains
> 		# unique per filesystem instance (often by deriving it
> 		# from the UUID and underlying block device.)
> 		;;

> 	fi
esac

> }
> 
> --D
> 

Yeah sure, suggestions applied.

Thanks, Anand


  reply	other threads:[~2026-07-21 22:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 11:20 [PATCH v7 0/11] fstests: add test coverage for cloned filesystem ids Anand Jain
2026-06-17 11:20 ` [PATCH v7 01/11] fstests: add _loop_image_create_clone() helper Anand Jain
2026-07-01 17:07   ` Darrick J. Wong
2026-07-21 22:38     ` Anand Suveer Jain
2026-06-17 11:20 ` [PATCH v7 02/11] fstests: add _clone_mount_option() helper Anand Jain
2026-06-17 11:20 ` [PATCH v7 03/11] fstests: add FSNOTIFYWAIT_PROG Anand Jain
2026-06-17 11:20 ` [PATCH v7 04/11] fstests: add _require_unique_f_fsid() helper Anand Jain
2026-07-01 17:11   ` Darrick J. Wong
2026-07-21 22:37     ` Anand Suveer Jain [this message]
2026-06-17 11:20 ` [PATCH v7 05/11] fstests: verify fanotify isolation on cloned filesystems Anand Jain
2026-07-01 17:12   ` Darrick J. Wong
2026-07-21 22:36     ` Anand Suveer Jain
2026-06-17 11:20 ` [PATCH v7 06/11] fstests: verify f_fsid for " Anand Jain
2026-07-01 17:33   ` Darrick J. Wong
2026-07-21 22:36     ` Anand Suveer Jain
2026-07-21 22:57       ` Darrick J. Wong
2026-07-21 23:21         ` Anand Suveer Jain
2026-07-21 23:25           ` Darrick J. Wong
2026-06-17 11:20 ` [PATCH v7 07/11] fstests: verify libblkid resolution of duplicate UUIDs Anand Jain
2026-06-17 11:20 ` [PATCH v7 08/11] fstests: verify IMA isolation on cloned filesystems Anand Jain
2026-06-17 11:20 ` [PATCH v7 09/11] fstests: verify exportfs file handles " Anand Jain
2026-06-17 11:20 ` [PATCH v7 10/11] fstests: add _change_metadata_uuid helper Anand Jain
2026-06-17 11:20 ` [PATCH v7 11/11] fstests: test UUID consistency for clones with metadata_uuid Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48637a77-b2ec-47e8-ac77-d397660c482b@kernel.org \
    --to=asj@kernel.org \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox